Skip to content

Conversation

@lukewalczak
Copy link
Member

Motivation

This PR improves the behavior of the Surface component regarding flexbox layout and style inheritance, especially on iOS, and introduces a new internal container prop for more explicit control.
This prop allows internal components (like Button, Card, etc.) to explicitly specify whether the Surface should behave as a main layout container or as a simple wrapper.

Related issue

#3652
#4632

Test plan

Tested against two mentioned issues:

Zrzut ekranu 2025-05-15 o 13 01 37

@lukewalczak
Copy link
Member Author

@durandt could you please whether it fixes the issue?

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@durandt
Copy link
Contributor

durandt commented May 15, 2025

@durandt could you please whether it fixes the issue?

Sure @lukewalczak , I would be glad to help. I have only been working with RN for a year or so, what would be the best way to test your PR? Apply-patch? Or do you have the build artifacts somewhere? (I didn't find them in the PR build)

(EDIT: I'll try cloning the repo, building with yarn and npm install react-native-paper /path/to/module in my RN app)

@lukewalczak
Copy link
Member Author

You can try to install it from the branch, by editing package.json:

    "react-native-paper": "git+https://github.com/callstack/react-native-paper.git#ee244bd4e776c3a082a3f5e64aa331f8f736c39e",

If you have cloned repo, you can also try use the yalc tool to link the package to the project

@durandt
Copy link
Contributor

durandt commented May 15, 2025

Thank you very much @lukewalczak 🙏, that now works as intended with the provided patch. Wishing you a nice day 🌤️

@lukewalczak lukewalczak merged commit 12ce89d into main May 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants