CI configuration updated (#315)

* Turn on the JS Bundle build of Android and iOS

The commented part of CI workflow was about to be turned on once detox
is configured and ready to be used.

NOTE:
This commit is about to TEST whether this part is still valid.
If the CI workflow fail and cannot be fixed it should be removed or
replaced if possible.

* Remove JS Bundle build from analyse step

* Upgrade RN orb to 5.5.0

* Remove Detox from the package testing

The Detox still have an issue with React Native and seems to not going
forward with more support for it.
It should not be slowing down the CI development - more convenient will
be to configure the build and tests in old-fashioned way.

* Build Windows OS Example app

The Windows Example app is built using the [email protected] orb of CircleCI
This configuration is based on self installed dependencies, as there's
no `install` job in the CI workflow.

This commit also adds the msbuild.binlog to the ignored files - this is
the build result log file which can be changed anytime app is built.

* Fix: missing downloadDependencies task for Android

The Android example app could not be compiled due to no
`downloadDependencies` task. This is fixed by adding it to the
build.gradle configuration, so that rn/android can utilize it.

* Remove release and detox jobs for Android

* Rename  to

* Run tests separately from 'verify' job

* Include Windows example build in workflow

* Use custom example build job for iOS app

The rn/ios_build job had an issue of being unable to build the workspace
which would result in the static libraries unable to be found in the
project.
To avoid that the custom job has been implemented, which builds the iOS
app from a workspace point of view, which has all the deps already
linked and can be successfully used to verify the build.

* Simplify and rename CI workflow to slider-full-ci

* Regenarate the UWP certificate for Windows Example

* Use local Slider package in the example source

* Fix: unrecognized && syntax in powershell

Author: BartoszKlonowski

.circleci/config.yml

@@ -1,7 +1,8 @@
 version: 2.1
 
 orbs:
-  rn: react-native-community/[email protected]
+  rn: react-native-community/[email protected]
+  windows: circleci/[email protected]
 
 jobs:
   checkout_code:
@@ -11,7 +12,8 @@ jobs:
       - persist_to_workspace:
           root: .
           paths: .
-  analyse:
+
+  verify:
     executor: rn/linux_js
     steps:
       - attach_workspace:
@@ -23,16 +25,49 @@ jobs:
       - run:
           name: Flow
           command: yarn run validate:flow
+
+  test:
+    executor: rn/linux_js
+    steps:
+      - attach_workspace:
+          at: .
+      - rn/yarn_install
       - run:
-          name: Jest
+          name: Run unit tests with Jest
           command: yarn run test:jest
-      # TODO: Uncomment after fixing detox setup
-      # - run:
-      #     name: Build Android JavaScript Bundle
-      #     command: yarn run test:detox:android:bundle:release
-      # - run:
-      #     name: Build iOS JavaScript Bundle
-      #     command: yarn run test:detox:ios:bundle:release
+
+  build_example_windows:
+    executor:
+      name: windows/default
+      shell: powershell
+    steps:
+      - checkout
+      - run:
+          name: Install examples
+          command: cd src; yarn install; cd ../example; yarn install --force --frozen-lockfile
+      - run:
+          name: "Restore NuGet packages for Components"
+          command: nuget restore .\example\windows\SliderTestWindows.sln
+      - run:
+          name: "Restore .NET dependencies"
+          command: msbuild -t:restore .\example\windows\SliderTestWindows.sln
+      - run:
+          name: Build example Windows
+          command: cd example; npx react-native run-windows --no-packager --no-launch --arch x64 --logging --no-deploy
+
+  build_example_ios:
+    executor: rn/macos
+    steps:
+      - checkout
+      - run:
+          name: Install deps
+          command: cd src && yarn install && cd ../example && yarn install --force --frozen-lockfile
+      - run:
+          name: Install Pods
+          command: cd example && npx pod-install
+      - run:
+          name: Build the iOS example project
+          command: cd example/ios && export RCT_NO_LAUNCH_PACKAGER=true && xcodebuild -workspace example.xcworkspace -destination 'platform=iOS Simulator,name=iPhone 11' -scheme example -parallelizeTargets -configuration Debug -derivedDataPath build  -UseModernBuildSystem=YES
 
   # To be uncommented as a part of https://github.com/react-native-community/react-native-slider/issues/34
   # publish:
@@ -46,41 +81,27 @@ jobs:
   #         command: yarn ci:publish
 
 workflows:
-  test:
+  slider-full-ci:
     jobs:
       - checkout_code
-      - analyse:
+      - verify:
           requires:
             - checkout_code
-      # Disabled until Detox works correctly with 0.60
-      # - rn/android_build:
-      #     name: build_android_debug
-      #     project_path: "example/android"
-      #     build_type: debug
-      #     requires:
-      #       - analyse
-      # - rn/android_build:
-      #     name: build_android_release
-      #     project_path: "example/android"
-      #     build_type: release
-      #     requires:
-      #       - analyse
-      # - rn/android_test:
-      #     detox_configuration: "android.emu.release"
-      #     detox_loglevel: "trace"
-      #     requires:
-      #       - build_android_release
-      # - rn/ios_build_and_test:
-      #     project_path: "example/ios/example.xcworkspace"
-      #     derived_data_path: "example/ios/build"
-      #     device: "iPhone X"
-      #     build_configuration: "Release"
-      #     scheme: "example"
-      #     detox_configuration: "ios.sim.release"
-      #     detox_loglevel: "trace"
-      #     requires:
-      #       - analyse
-      # To be uncommented as a part of https://github.com/react-native-community/react-native-slider/issues/34
+      - test:
+          requires:
+            - verify
+      - build_example_windows:
+          requires:
+            - verify
+      - rn/android_build:
+          name: build_android_debug
+          project_path: "example/android"
+          build_type: debug
+          requires:
+            - verify
+      - build_example_ios:
+          requires:
+            - verify
       # - publish:
       #     requires:
       #       - analyse

.gitignore

@@ -2,6 +2,10 @@
 #
 .DS_Store
 
+# Windows OS
+#
+msbuild.binlog
+
 # Xcode
 #
 build/

example/android/app/build.gradle

@@ -184,6 +184,19 @@ task copyDownloadableDepsToLibs(type: Copy) {
     into 'libs'
 }
 
+task downloadDependencies() {
+  description 'Download all dependencies to the Gradle cache'
+  doLast {
+    configurations.findAll().each { config ->
+      if (config.name.contains("minReactNative") && config.canBeResolved) {
+        print config.name
+        print '\n'
+        config.files
+      }
+    }
+  }
+}
+
 apply from: file("../../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle");
 // set custom root because we're in a monorepo
 applyNativeModulesAppBuildGradle(project)

example/e2e/config.json

@@ -10,7 +10,7 @@
     "run:web": "expo web"
   },
   "dependencies": {
-    "@react-native-community/slider": "^4.0.0-rc.2",
+    "@react-native-community/slider": "file:../src/",
     "babel-preset-expo": "^8.2.1",
     "expo": "^37.0.12",
     "react-dom": "~16.9.0",

example/e2e/init.js

@@ -8,14 +8,14 @@
 
  <Identity
     Name="sliderExample"
-    Publisher="CN=igklemen"
+    Publisher="CN=Bartosz Klonowski"
     Version="1.0.0.0" />
 
   <mp:PhoneIdentity PhoneProductId="359e3698-40e8-432a-a406-1213a9404462" PhonePublisherId="00000000-0000-0000-0000-000000000000"/>
 
   <Properties>
     <DisplayName>SliderTestWindows</DisplayName>
-    <PublisherDisplayName>igklemen</PublisherDisplayName>
+    <PublisherDisplayName>BartoszKlonowski</PublisherDisplayName>
     <Logo>Assets\StoreLogo.png</Logo>
   </Properties>
 

example/e2e/testCases/example.e2e.js

@@ -14,9 +14,9 @@
     <ApplicationType>Windows Store</ApplicationType>
     <ApplicationTypeRevision>10.0</ApplicationTypeRevision>
     <WindowsTargetPlatformVersion Condition=" '$(WindowsTargetPlatformVersion)' == '' ">10.0.18362.0</WindowsTargetPlatformVersion>
-    <WindowsTargetPlatformMinVersion>10.0.16299.0</WindowsTargetPlatformMinVersion>
     <PackageCertificateKeyFile>SliderTestWindows_TemporaryKey.pfx</PackageCertificateKeyFile>
-    <PackageCertificateThumbprint>2B865F049A8EC254802CBE811120971BD5F2CDB5</PackageCertificateThumbprint>
+    <WindowsTargetPlatformMinVersion>10.0.16299.0</WindowsTargetPlatformMinVersion>
+    <PackageCertificateThumbprint>F4D37D3346135805DB0E33DEE0E9A100AB53BE42</PackageCertificateThumbprint>
     <PackageCertificatePassword>password</PackageCertificatePassword>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
@@ -146,6 +146,7 @@
   <ItemGroup>
     <None Include="packages.config" />
     <None Include="PropertySheet.props" />
+    <None Include="SliderTestWindows_TemporaryKey.pfx" />
     <Text Include="readme.txt">
       <DeploymentContent>false</DeploymentContent>
     </Text>
@@ -158,6 +159,7 @@
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <PropertyGroup Label="ReactNativeWindowsNodeProps">
     <ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == ''">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'node_modules\react-native-windows\package.json'))\node_modules\react-native-windows\</ReactNativeWindowsDir>
+    <AppxPackageSigningEnabled>True</AppxPackageSigningEnabled>
   </PropertyGroup>
   <ImportGroup Label="ReactNativeWindowsNodeTargets">
     <Import Project="$(ReactNativeWindowsDir)PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.props" Condition="Exists('$(ReactNativeWindowsDir)PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.props')" />

example/package.json

@@ -53,6 +53,7 @@
   <ItemGroup>
     <None Include="PropertySheet.props" />
     <None Include="packages.config" />
+    <None Include="SliderTestWindows_TemporaryKey.pfx" />
   </ItemGroup>
   <ItemGroup>
     <Text Include="readme.txt" />