[Fabric] Refactor events, remove unused code (#422)

* fix: move ReactSliderShadowNode to oldarch

* fix: refactor to RCTModernEventEmitter closes #412

* fix: minimize diff & indentations

Author: okwasniewski

package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java

@@ -10,7 +10,7 @@
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
-import com.facebook.react.uimanager.events.RCTEventEmitter;
+import com.facebook.react.uimanager.events.RCTModernEventEmitter;
 
 /**
  * Event emitted by a ReactSliderManager when user changes slider position.
@@ -46,8 +46,9 @@ public String getEventName() {
   public short getCoalescingKey() {
     return 0;
   }
+
   @Override
-  public void dispatch(RCTEventEmitter rctEventEmitter) {
+  public void dispatchModern(RCTModernEventEmitter rctEventEmitter) {
     rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData());
   }
 

package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java

@@ -5,18 +5,11 @@
 import android.graphics.drawable.Drawable;
 import android.graphics.drawable.LayerDrawable;
 import android.os.Build;
-import android.view.View;
-import android.widget.SeekBar;
 
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.common.MapBuilder;
-import com.facebook.react.uimanager.LayoutShadowNode;
 import com.facebook.react.uimanager.ThemedReactContext;
-import com.facebook.yoga.YogaMeasureFunction;
-import com.facebook.yoga.YogaMeasureMode;
-import com.facebook.yoga.YogaMeasureOutput;
-import com.facebook.yoga.YogaNode;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -28,41 +21,6 @@ public class ReactSliderManagerImpl {
 
     public static final String REACT_CLASS = "RNCSlider";
 
-    public static class ReactSliderShadowNode extends LayoutShadowNode implements
-            YogaMeasureFunction {
-
-        private int mWidth;
-        private int mHeight;
-        private boolean mMeasured;
-
-        public ReactSliderShadowNode() {
-            initMeasureFunction();
-        }
-
-        private void initMeasureFunction() {
-            setMeasureFunction(this);
-        }
-
-        @Override
-        public long measure(
-                YogaNode node,
-                float width,
-                YogaMeasureMode widthMode,
-                float height,
-                YogaMeasureMode heightMode) {
-            if (!mMeasured) {
-                SeekBar reactSlider = new ReactSlider(getThemedContext(), null);
-                final int spec = View.MeasureSpec.makeMeasureSpec(0, View.MeasureSpec.UNSPECIFIED);
-                reactSlider.measure(spec, spec);
-                mWidth = reactSlider.getMeasuredWidth();
-                mHeight = reactSlider.getMeasuredHeight();
-                mMeasured = true;
-            }
-
-            return YogaMeasureOutput.make(mWidth, mHeight);
-        }
-    }
-
     public static ReactSlider createViewInstance(ThemedReactContext context) {
         ReactSlider slider = new ReactSlider(context, null);
 

package/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java

@@ -10,7 +10,7 @@
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
-import com.facebook.react.uimanager.events.RCTEventEmitter;
+import com.facebook.react.uimanager.events.RCTModernEventEmitter;
 
 /**
  * Event emitted when the user finishes dragging the slider.
@@ -46,7 +46,7 @@ public boolean canCoalesce() {
     }
 
     @Override
-    public void dispatch(RCTEventEmitter rctEventEmitter) {
+    public void dispatchModern(RCTModernEventEmitter rctEventEmitter) {
         rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData());
     }
 

package/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java

@@ -10,7 +10,7 @@
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
-import com.facebook.react.uimanager.events.RCTEventEmitter;
+import com.facebook.react.uimanager.events.RCTModernEventEmitter;
 
 /**
  * Event emitted when the user starts dragging the slider.
@@ -46,7 +46,7 @@ public boolean canCoalesce() {
     }
 
     @Override
-    public void dispatch(RCTEventEmitter rctEventEmitter) {
+    public void dispatchModern(RCTModernEventEmitter rctEventEmitter) {
         rctEventEmitter.receiveEvent(getViewTag(), getEventName(), serializeEventData());
     }
 

package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java

@@ -6,8 +6,6 @@
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
-import com.facebook.react.common.MapBuilder;
-import com.facebook.react.uimanager.LayoutShadowNode;
 import com.facebook.react.uimanager.SimpleViewManager;
 import com.facebook.react.uimanager.ThemedReactContext;
 import com.facebook.react.uimanager.UIManagerHelper;
@@ -85,16 +83,6 @@ public String getName() {
     return ReactSliderManagerImpl.REACT_CLASS;
   }
 
-  @Override
-  public LayoutShadowNode createShadowNodeInstance() {
-    return new ReactSliderManagerImpl.ReactSliderShadowNode();
-  }
-
-  @Override
-  public Class getShadowNodeClass() {
-    return ReactSliderManagerImpl.ReactSliderShadowNode.class;
-  }
-
   @Override
   protected ReactSlider createViewInstance(ThemedReactContext context) {
     return ReactSliderManagerImpl.createViewInstance(context);

package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java

@@ -4,16 +4,21 @@
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
-import com.facebook.react.common.MapBuilder;
 import com.facebook.react.uimanager.LayoutShadowNode;
 import com.facebook.react.uimanager.SimpleViewManager;
 import com.facebook.react.uimanager.ThemedReactContext;
 import com.facebook.react.uimanager.UIManagerModule;
 import com.facebook.react.uimanager.ViewProps;
 import com.facebook.react.uimanager.annotations.ReactProp;
 import java.util.Map;
+import android.view.View;
 import javax.annotation.Nullable;
 
+import com.facebook.yoga.YogaMeasureFunction;
+import com.facebook.yoga.YogaMeasureMode;
+import com.facebook.yoga.YogaMeasureOutput;
+import com.facebook.yoga.YogaNode;
+
 /**
  * Manages instances of {@code ReactSlider}.
  */
@@ -60,15 +65,50 @@ public void onStopTrackingTouch(SeekBar seekbar) {
   public String getName() {
     return ReactSliderManagerImpl.REACT_CLASS;
   }
+  
+  static class ReactSliderShadowNode extends LayoutShadowNode implements
+      YogaMeasureFunction {
+
+    private int mWidth;
+    private int mHeight;
+    private boolean mMeasured;
+
+    private ReactSliderShadowNode() {
+      initMeasureFunction();
+    }
+
+    private void initMeasureFunction() {
+      setMeasureFunction(this);
+    }
+
+    @Override
+    public long measure(
+        YogaNode node,
+        float width,
+        YogaMeasureMode widthMode,
+        float height,
+        YogaMeasureMode heightMode) {
+      if (!mMeasured) {
+        SeekBar reactSlider = new ReactSlider(getThemedContext(), null);
+        final int spec = View.MeasureSpec.makeMeasureSpec(0, View.MeasureSpec.UNSPECIFIED);
+        reactSlider.measure(spec, spec);
+        mWidth = reactSlider.getMeasuredWidth();
+        mHeight = reactSlider.getMeasuredHeight();
+        mMeasured = true;
+      }
+
+      return YogaMeasureOutput.make(mWidth, mHeight);
+    }
+  }
 
   @Override
   public LayoutShadowNode createShadowNodeInstance() {
-    return new ReactSliderManagerImpl.ReactSliderShadowNode();
+    return new ReactSliderShadowNode();
   }
 
   @Override
   public Class getShadowNodeClass() {
-    return ReactSliderManagerImpl.ReactSliderShadowNode.class;
+    return ReactSliderShadowNode.class;
   }
 
   @Override