[Fabric] Fix hot reloading causing photo jumps (#413)

Author: okwasniewski

package/ios/RNCSliderComponentView.h

@@ -7,6 +7,7 @@
 NS_ASSUME_NONNULL_BEGIN
 
 typedef void (^RNCLoadImageCompletionBlock)(NSError * _Nullable error, UIImage * _Nullable image);
+typedef void (^RNCLoadImageFailureBlock)();
 
 @interface RNCSliderComponentView : RCTViewComponentView
 

package/ios/RNCSliderComponentView.mm

@@ -195,39 +195,61 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
             dispatch_async(dispatch_get_main_queue(), ^{
                 [self->slider setThumbImage:image];
             });
+        }
+        failureBlock:^{
+            [self->slider setThumbImage:nil];
         }];
     }
     if (oldScreenProps.trackImage != newScreenProps.trackImage) {
         [self loadImageFromImageSource:newScreenProps.trackImage completionBlock:^(NSError *error, UIImage *image) {
             dispatch_async(dispatch_get_main_queue(), ^{
                 [self->slider setTrackImage:image];
             });
+        }
+        failureBlock:^{
+            [self->slider setTrackImage:nil];
         }];
     }
     if (oldScreenProps.minimumTrackImage != newScreenProps.minimumTrackImage) {
         [self loadImageFromImageSource:newScreenProps.minimumTrackImage completionBlock:^(NSError *error, UIImage *image) {
             dispatch_async(dispatch_get_main_queue(), ^{
                 [self->slider setMinimumTrackImage:image];
             });
+        }
+        failureBlock:^{
+            [self->slider setMinimumTrackImage:nil];
         }];
     }
     if (oldScreenProps.maximumTrackImage != newScreenProps.maximumTrackImage) {
         [self loadImageFromImageSource:newScreenProps.maximumTrackImage completionBlock:^(NSError *error, UIImage *image) {
             dispatch_async(dispatch_get_main_queue(), ^{
                 [self->slider setMaximumTrackImage:image];
             });
+        }
+        failureBlock:^{
+            [self->slider setMaximumTrackImage:nil];
         }];
     }
     [super updateProps:props oldProps:oldProps];
 }
 
 
 // TODO temporarily using bridge, workaround for https://github.com/reactwg/react-native-new-architecture/discussions/31#discussioncomment-2717047, rewrite when Meta comes with a solution.
-- (void)loadImageFromImageSource:(ImageSource)source completionBlock:(RNCLoadImageCompletionBlock)completionBlock
+- (void)loadImageFromImageSource:(ImageSource)source completionBlock:(RNCLoadImageCompletionBlock)completionBlock failureBlock:(RNCLoadImageFailureBlock)failureBlock
 {
     NSString *uri = [[NSString alloc] initWithUTF8String:source.uri.c_str()];
     if ((BOOL)uri.length) {
-        [[[RCTBridge currentBridge] moduleForName:@"ImageLoader"] loadImageWithURLRequest:NSURLRequestFromImageSource(source) size:CGSizeMake(source.size.width, source.size.height) scale:source.scale clipped:NO resizeMode:RCTResizeModeCover progressBlock:nil partialLoadBlock:nil completionBlock:completionBlock];
+        [[[RCTBridge currentBridge] moduleForName:@"ImageLoader"]
+        loadImageWithURLRequest:NSURLRequestFromImageSource(source)
+        size:CGSizeMake(source.size.width, source.size.height)
+        scale:source.scale
+        clipped:NO
+        resizeMode:RCTResizeModeCover
+        progressBlock:nil
+        partialLoadBlock:nil
+        completionBlock:completionBlock];
+    } else {
+        failureBlock();
     }
 }