refactor: adjust finding to experiment results

Author: mdjastrzebski

src/helpers/accessibility.ts

@@ -143,9 +143,8 @@ export function getRole(element: ReactTestInstance): Role | AccessibilityRole {
     return 'text';
   }
 
-  if (isHostImage(element) && element.props.alt) {
-    return 'img';
-  }
+  // Note: host Image elements report "image" role in screen reader only on Android, but not on iOS.
+  // It's better to require explicit role for Image elements.
 
   return 'none';
 }

src/queries/__tests__/role.test.tsx

@@ -227,12 +227,22 @@ describe('supports name option', () => {
   });
 
   test('supports host Image element with "alt" prop', () => {
-    render(<Image alt="An elephant" testID="image" />);
+    render(
+      <>
+        <Image testID="image1" role="img" alt="an elephant" />
+        <Image testID="image2" accessibilityRole="image" alt="a tiger" />
+      </>,
+    );
+
+    const expectedElement1 = screen.getByTestId('image1');
+    expect(screen.getByRole('img', { name: 'an elephant' })).toBe(expectedElement1);
+    expect(screen.getByRole('image', { name: 'an elephant' })).toBe(expectedElement1);
+    expect(screen.getByRole(/img/, { name: /elephant/ })).toBe(expectedElement1);
 
-    const expectedElement = screen.getByTestId('image');
-    expect(screen.getByRole('img', { name: 'An elephant' })).toBe(expectedElement);
-    expect(screen.getByRole('image', { name: 'An elephant' })).toBe(expectedElement);
-    expect(screen.getByRole(/img/, { name: 'An elephant' })).toBe(expectedElement);
+    const expectedElement2 = screen.getByTestId('image2');
+    expect(screen.getByRole('img', { name: 'a tiger' })).toBe(expectedElement2);
+    expect(screen.getByRole('image', { name: 'a tiger' })).toBe(expectedElement2);
+    expect(screen.getByRole(/img/, { name: /tiger/ })).toBe(expectedElement2);
   });
 });