Skip to content

Commit 16e350f

Browse files
refactor: remove unsafe sync functions (#1855)
1 parent 2f582ac commit 16e350f

File tree

18 files changed

+22
-1428
lines changed

18 files changed

+22
-1428
lines changed

codemods/v14-async-functions/tests/fixtures/skip-variants/expected.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import {
22
render,
33
act,
44
renderHook,
5-
unsafe_act,
6-
unsafe_renderHookSync,
75
} from '@testing-library/react-native';
86

97
test('skips unsafe variants', async () => {
@@ -13,13 +11,7 @@ test('skips unsafe variants', async () => {
1311
// Should be transformed
1412
});
1513

16-
unsafe_act(() => {
17-
// Should NOT be transformed
18-
});
19-
2014
const { result } = await renderHook(() => ({ value: 42 }));
2115

22-
unsafe_renderHookSync(() => ({ value: 43 }));
23-
2416
await render(<MyComponent />);
2517
});

codemods/v14-async-functions/tests/fixtures/skip-variants/input.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import {
22
render,
33
act,
44
renderHook,
5-
unsafe_act,
6-
unsafe_renderHookSync,
75
renderAsync,
86
} from '@testing-library/react-native';
97

@@ -14,13 +12,7 @@ test('skips unsafe variants', async () => {
1412
// Should be transformed
1513
});
1614

17-
unsafe_act(() => {
18-
// Should NOT be transformed
19-
});
20-
2115
const { result } = renderHook(() => ({ value: 42 }));
2216

23-
unsafe_renderHookSync(() => ({ value: 43 }));
24-
2517
await renderAsync(<MyComponent />);
2618
});

src/__tests__/__snapshots__/unsafe-render-sync.test.tsx.snap

Lines changed: 0 additions & 39 deletions
This file was deleted.

src/__tests__/cleanup.test.tsx

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as React from 'react';
22
import { View } from 'react-native';
33

4-
import { cleanup, render, unsafe_renderSync } from '../pure';
4+
import { cleanup, render } from '../pure';
55

66
class Test extends React.Component<{ onUnmount: () => void }> {
77
componentWillUnmount() {
@@ -24,14 +24,3 @@ test('cleanup after render', async () => {
2424
await cleanup();
2525
expect(fn).toHaveBeenCalledTimes(2);
2626
});
27-
28-
test('cleanup after unsafe_renderSync', async () => {
29-
const fn = jest.fn();
30-
31-
unsafe_renderSync(<Test onUnmount={fn} />);
32-
unsafe_renderSync(<Test onUnmount={fn} />);
33-
expect(fn).not.toHaveBeenCalled();
34-
35-
await cleanup();
36-
expect(fn).toHaveBeenCalledTimes(2);
37-
});

0 commit comments

Comments
 (0)