chore: simplify find-all

Author: mdjastrzebski

src/helpers/host-component-names.tsx

@@ -2,9 +2,9 @@ import * as React from 'react';
 import { Image, Modal, ScrollView, Switch, Text, TextInput, View } from 'react-native';
 import { configureInternal, getConfig, HostComponentNames } from '../config';
 import { HostElement } from '../renderer/host-element';
-import { renderWithAct } from '../render-act';
 import { createRenderer } from '../renderer/renderer';
 import act from '../act';
+import { findAll } from './find-all';
 
 const userConfigErrorMessage = `There seems to be an issue with your configuration that prevents React Native Testing Library from working correctly.
 Please check if you are using compatible versions of React Native and React Native Testing Library.`;
@@ -62,8 +62,9 @@ function detectHostComponentNames(): HostComponentNames {
   }
 }
 
-function getByTestId(instance: HostElement, testID: string) {
-  const nodes = instance.findAll(
+function getByTestId(element: HostElement, testID: string) {
+  const nodes = findAll(
+    element,
     (node) => typeof node.type === 'string' && node.props.testID === testID,
   );
 

src/matchers/to-contain-element.tsx

@@ -1,5 +1,6 @@
 import { matcherHint, RECEIVED_COLOR } from 'jest-matcher-utils';
 import { HostElement } from '../renderer/host-element';
+import { findAll } from '../helpers/find-all';
 import { checkHostElement, formatElement } from './utils';
 
 export function toContainElement(
@@ -15,7 +16,7 @@ export function toContainElement(
 
   let matches: HostElement[] = [];
   if (element) {
-    matches = container.findAll((node) => node === element);
+    matches = findAll(container, (node) => node === element);
   }
 
   return {

src/renderer/host-element.ts

@@ -3,10 +3,6 @@ import { Container, Instance, TextInstance } from './reconciler';
 export type HostNode = HostElement | string;
 export type HostElementProps = Record<string, any>;
 
-type FindOptions = {
-  deep?: boolean;
-};
-
 const instanceToHostElementMap = new WeakMap<Container | Instance, HostElement>();
 
 export class HostElement {
@@ -89,34 +85,4 @@ export class HostElement {
         throw new Error(`Unexpected node type in HostElement.fromInstance: ${instance.tag}`);
     }
   }
-
-  findAll(predicate: (element: HostElement) => boolean, options?: FindOptions): HostElement[] {
-    return findAll(this, predicate, options);
-  }
-}
-
-function findAll(
-  root: HostElement,
-  predicate: (element: HostElement) => boolean,
-  options?: FindOptions,
-): HostElement[] {
-  const deep = options?.deep ?? true;
-  const results = [];
-
-  if (predicate(root)) {
-    results.push(root);
-    if (!deep) {
-      return results;
-    }
-  }
-
-  root.children.forEach((child) => {
-    if (typeof child === 'string') {
-      return;
-    }
-
-    results.push(...findAll(child, predicate, options));
-  });
-
-  return results;
 }