refactor: final tweaks

Author: mdjastrzebski

src/user-event/type/__tests__/type.test.tsx

@@ -1,11 +1,6 @@
 import * as React from 'react';
 import { TextInput, TextInputProps, View } from 'react-native';
-import {
-  createEventLogger,
-  getEventsNames,
-  lastEvent,
-  lastEventPayload,
-} from '../../../test-utils';
+import { createEventLogger, getEventsNames, lastEventPayload } from '../../../test-utils';
 import { render, screen } from '../../..';
 import { userEvent } from '../..';
 

src/user-event/type/type.ts

@@ -48,11 +48,8 @@ export async function type(
   for (const key of keys) {
     const previousText = element.props.value ?? currentText;
     const proposedText = applyKey(previousText, key);
-    let isAccepted = false;
-    if (isTextChangeAllowed(element, proposedText)) {
-      currentText = proposedText;
-      isAccepted = true;
-    }
+    const isAccepted = isTextChangeAccepted(element, proposedText);
+    currentText = isAccepted ? proposedText : previousText;
 
     await emitTypingEvents(element, {
       config: this.config,
@@ -138,7 +135,7 @@ function applyKey(text: string, key: string) {
   return text + key;
 }
 
-function isTextChangeAllowed(element: ReactTestInstance, text: string) {
+function isTextChangeAccepted(element: ReactTestInstance, text: string) {
   const maxLength = element.props.maxLength;
   return maxLength === undefined || text.length <= maxLength;
 }