self code review

Author: mdjastrzebski

src/__tests__/fire-event-async.test.tsx

@@ -644,16 +644,14 @@ describe('React.Suspense integration', () => {
 
 test('should handle unmounted elements gracefully in async mode', async () => {
   const onPress = jest.fn();
-  const result = render(
+  render(
     <TouchableOpacity onPress={onPress}>
       <Text>Test</Text>
     </TouchableOpacity>,
   );
 
   const element = screen.getByText('Test');
-
-  // Unmount the component
-  result.unmount();
+  screen.unmount();
 
   // Firing async event on unmounted element should not crash
   await fireEventAsync.press(element);

src/__tests__/fire-event.test.tsx

@@ -556,44 +556,16 @@ describe('native events', () => {
 
 test('should handle unmounted elements gracefully', () => {
   const onPress = jest.fn();
-  const result = render(
+  render(
     <TouchableOpacity onPress={onPress}>
       <Text>Test</Text>
     </TouchableOpacity>,
   );
 
   const element = screen.getByText('Test');
-
-  // Unmount the component
-  result.unmount();
+  screen.unmount();
 
   // Firing event on unmounted element should not crash
   fireEvent.press(element);
   expect(onPress).not.toHaveBeenCalled();
 });
-
-test('should handle invalid scroll event data gracefully', () => {
-  const onScrollSpy = jest.fn();
-  render(<ScrollView testID="scroll-view" onScroll={onScrollSpy} />);
-
-  const scrollView = screen.getByTestId('scroll-view');
-
-  // Test with malformed event data that would cause an error in tryGetContentOffset
-  fireEvent.scroll(scrollView, { malformed: 'data' });
-  expect(onScrollSpy).toHaveBeenCalled();
-});
-
-test('should handle scroll event with invalid contentOffset', () => {
-  const onScrollSpy = jest.fn();
-  render(<ScrollView testID="scroll-view" onScroll={onScrollSpy} />);
-
-  const scrollView = screen.getByTestId('scroll-view');
-
-  // Test with event data that has invalid contentOffset structure
-  fireEvent.scroll(scrollView, {
-    nativeEvent: {
-      contentOffset: { x: 'invalid', y: null },
-    },
-  });
-  expect(onScrollSpy).toHaveBeenCalled();
-});

src/__tests__/render-async.test.tsx

@@ -59,11 +59,6 @@ test('renderAsync supports concurrent rendering option', async () => {
   expect(screen.root).toBeOnTheScreen();
 });
 
-test('renderAsync supports legacy rendering option', async () => {
-  await renderAsync(<View testID="test" />, { concurrentRoot: false });
-  expect(screen.root).toBeOnTheScreen();
-});
-
 test('rerender function throws error when used with renderAsync', async () => {
   await renderAsync(<Banana />);
 

src/__tests__/render.test.tsx

@@ -244,20 +244,20 @@ test('supports concurrent rendering', () => {
   expect(screen.root).toBeOnTheScreen();
 });
 
-test('updateAsync updates the component asynchronously', async () => {
+test('rerenderAsync updates the component asynchronously', async () => {
   const fn = jest.fn();
   const result = render(<Banana onUpdate={fn} />);
 
-  await result.updateAsync(<Banana onUpdate={fn} />);
+  await result.rerenderAsync(<Banana onUpdate={fn} />);
 
   expect(fn).toHaveBeenCalledTimes(1);
 });
 
-test('rerenderAsync is an alias for updateAsync', async () => {
+test('updateAsync is an alias for rerenderAsync', async () => {
   const fn = jest.fn();
   const result = render(<Banana onUpdate={fn} />);
 
-  await result.rerenderAsync(<Banana onUpdate={fn} />);
+  await result.updateAsync(<Banana onUpdate={fn} />);
 
   expect(fn).toHaveBeenCalledTimes(1);
 });

website/docs/13.x/docs/api/screen.mdx

@@ -100,7 +100,7 @@ Async version of `unmount` designed for working with React 19 and React Suspense
 
 :::note
 
-Usually you should not need to call `unmount` as it is done automatically if your test runner supports `afterEach` hook (like Jest, mocha, Jasmine).
+Usually you should not need to call `unmountAsync` as it is done automatically if your test runner supports `afterEach` hook (like Jest, mocha, Jasmine).
 
 :::