Skip to content

Commit 07d9cf3

Browse files
Jack Popefacebook-github-bot
authored andcommitted
Back out "cleanup feature flag enableFabricCompleteRootInCommitPhase" (facebook#49565)
Summary: Pull Request resolved: facebook#49565 Original commit changeset: 6ed54f0fab45 Original Phabricator Diff: D69473992 Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D69924542 fbshipit-source-id: 6438d1f6e21728de662a060893b0f08f9285be73
1 parent 441744a commit 07d9cf3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

packages/react-native-fantom/runtime/mocks/ReactNativeInternalFeatureFlags.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,6 @@
99
* @oncall react_native
1010
*/
1111

12-
module.exports = {};
12+
module.exports = {
13+
enableFabricCompleteRootInCommitPhase: true,
14+
};

packages/react-native/Libraries/ReactNative/__tests__/ReactFabric-Suspense-itest.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@ describe('Suspense', () => {
185185
expect(resolveFunction).toBeNull();
186186
});
187187

188+
// TODO(T207868872): this test only succeeds with enableFabricCompleteRootInCommitPhase enabled.
189+
// enableFabricCompleteRootInCommitPhase is hardcoded to true in the testing environment.
188190
it('shows stale data while transition is happening', () => {
189191
cache.clear();
190192
cache.set(SquareId.Green, {color: 'green'});

0 commit comments

Comments
 (0)