fix: retrieve statusbar size using RCTUIStatusBarManager (facebook#45103)

okwasniewski · facebook-github-bot · commit 34cd195d9fbd · 2024-06-21T08:27:50.000-07:00
Summary: This PR changes the call from `RCTSharedApplication()` to retrieve the status bar size using the `RCTUIStatusBarManager()` method, a way which supports multi-window apps. ## Changelog: [IOS] [FIXED] - Retrieve status bar size using RCTUIStatusBarManager Pull Request resolved: facebook#45103 Test Plan: Check if the perf menu pops up in the correct spot. Reviewed By: javache Differential Revision: D58868503 Pulled By: cipolleschi fbshipit-source-id: db5fc80a712a8a18a2863cdfbbe44f48bafe9fc3
diff --git a/packages/react-native/React/CoreModules/RCTPerfMonitor.mm b/packages/react-native/React/CoreModules/RCTPerfMonitor.mm
@@ -171,7 +171,7 @@ - (UIPanGestureRecognizer *)gestureRecognizer
 - (UIView *)container
 {
   if (!_container) {
-    CGSize statusBarSize = RCTSharedApplication().statusBarFrame.size;
+    CGSize statusBarSize = RCTUIStatusBarManager().statusBarFrame.size;
     CGFloat statusBarHeight = statusBarSize.height;
     _container = [[UIView alloc] initWithFrame:CGRectMake(10, statusBarHeight, 180, RCTPerfMonitorBarHeight)];
     _container.layer.borderWidth = 2;

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ - (UIPanGestureRecognizer *)gestureRecognizer`
`171`	`171`	`- (UIView *)container`
`172`	`172`	`{`
`173`	`173`	`if (!_container) {`
`174`		`- CGSize statusBarSize = RCTSharedApplication().statusBarFrame.size;`
	`174`	`+ CGSize statusBarSize = RCTUIStatusBarManager().statusBarFrame.size;`
`175`	`175`	`CGFloat statusBarHeight = statusBarSize.height;`
`176`	`176`	`_container = [[UIView alloc] initWithFrame:CGRectMake(10, statusBarHeight, 180, RCTPerfMonitorBarHeight)];`
`177`	`177`	`_container.layer.borderWidth = 2;`