Skip to content

Commit 6bb75c7

Browse files
okwasniewskifacebook-github-bot
authored andcommitted
fix: set proper framework dependencies for built-in pods (facebook#45104)
Summary: Platforms like visionOS require explicit framework dependencies to be set in pods to build properly. For some reason linking on visionOS is more strict than on iOS but this might change in some future OS versions so it's good to have pods having exact dependencies. I've discussed that earlier with Saadnajmi and cipolleschi. Let me know if you are okay with this change. ## Changelog: [IOS] [FIXED] - set proper framework dependencies for built-in pods Pull Request resolved: facebook#45104 Test Plan: CI Green Reviewed By: dmytrorykun Differential Revision: D58943593 Pulled By: cipolleschi fbshipit-source-id: 3d2df4f3bbdf36704e09f5e39bfb838b2e0f3c99
1 parent f7fe688 commit 6bb75c7

File tree

7 files changed

+8
-2
lines changed

7 files changed

+8
-2
lines changed

packages/react-native/Libraries/Image/React-RCTImage.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Pod::Spec.new do |s|
4545
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
4646
"HEADER_SEARCH_PATHS" => header_search_paths.join(' ')
4747
}
48-
s.framework = ["Accelerate", "UIKit"]
48+
s.framework = ["Accelerate", "UIKit", "QuartzCore", "ImageIO", "CoreGraphics"]
4949

5050
s.dependency "RCT-Folly", folly_version
5151
s.dependency "RCTTypeSafety"

packages/react-native/Libraries/LinkingIOS/React-RCTLinking.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ Pod::Spec.new do |s|
4444
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
4545
"HEADER_SEARCH_PATHS" => header_search_paths.join(' ')
4646
}
47+
s.framework = "UIKit"
4748

4849
s.dependency "React-Core/RCTLinkingHeaders", version
4950
s.dependency "ReactCommon/turbomodule/core", version

packages/react-native/Libraries/NativeAnimation/React-RCTAnimation.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ Pod::Spec.new do |s|
4343
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
4444
"HEADER_SEARCH_PATHS" => header_search_paths.join(" ")
4545
}
46+
s.framework = ["UIKit", "QuartzCore"]
4647

4748
s.dependency "RCT-Folly", folly_version
4849
s.dependency "RCTTypeSafety"

packages/react-native/Libraries/PushNotificationIOS/React-RCTPushNotification.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Pod::Spec.new do |s|
4444
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
4545
"HEADER_SEARCH_PATHS" => header_search_paths.join(' ')
4646
}
47-
s.framework = "UserNotifications"
47+
s.framework = ["UIKit", "UserNotifications"]
4848

4949
s.dependency "RCTTypeSafety"
5050
s.dependency "React-Core/RCTPushNotificationHeaders"

packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ Pod::Spec.new do |s|
4949
"USE_HEADERMAP" => "YES",
5050
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
5151
"GCC_WARN_PEDANTIC" => "YES" }
52+
s.framework = "UIKit"
53+
5254
if ENV['USE_FRAMEWORKS']
5355
s.header_mappings_dir = './'
5456
end

packages/react-native/ReactCommon/react/renderer/graphics/React-graphics.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ Pod::Spec.new do |s|
4747
"platform/cxx",
4848
"platform/windows",
4949
s.header_dir = "react/renderer/graphics"
50+
s.framework = "UIKit"
5051

5152
if ENV['USE_FRAMEWORKS']
5253
s.module_name = "React_graphics"

packages/rn-tester/NativeModuleExample/ScreenshotManager.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ Pod::Spec.new do |s|
2121

2222
s.source_files = "**/*.{h,m,mm,swift}"
2323
s.requires_arc = true
24+
s.framework = ["UIKit", "CoreGraphics"]
2425

2526
install_modules_dependencies(s)
2627
end

0 commit comments

Comments
 (0)