Skip to content

Commit 927815b

Browse files
blakeffacebook-github-bot
authored andcommitted
use correct has to label hermes cache key (facebook#45061)
Summary: This incorrectly used the SHA from facebook/react-native instead of facebook/hermes to label the hermes cache key. This would bloat our cache by ~ 1.2GB for each PR. Changelog: [Internal] Pull Request resolved: facebook#45061 Test Plan: We should remove the existing entries for v4-hermes and track the growth over time. Reviewed By: cipolleschi Differential Revision: D58780475 Pulled By: blakef fbshipit-source-id: 0f192faa287f53154f1c8319be6783820d614018
1 parent 0c2fea5 commit 927815b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
else
4949
echo "Hermes Version file not found!!!"
5050
echo "Using the last commit from main for the build:"
51-
HERMES_TAG_SHA=$(git ls-remote https://github.com/$GITHUB_REPOSITORY main | cut -f 1 | tr -d '[:space:]')
51+
HERMES_TAG_SHA=$(git ls-remote https://github.com/facebook/hermes main | cut -f 1 | tr -d '[:space:]')
5252
echo "VERSION=$HERMES_TAG_SHA" >> "$GITHUB_OUTPUT"
5353
fi
5454
echo "Hermes commit is $HERMES_TAG_SHA"

.github/workflows/publish-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
else
4646
echo "Hermes Version file not found!!!"
4747
echo "Using the last commit from main for the build:"
48-
HERMES_TAG_SHA=$(git ls-remote https://github.com/$GITHUB_REPOSITORY main | cut -f 1 | tr -d '[:space:]')
48+
HERMES_TAG_SHA=$(git ls-remote https://github.com/facebook/hermes main | cut -f 1 | tr -d '[:space:]')
4949
echo "VERSION=$HERMES_TAG_SHA" >> "$GITHUB_OUTPUT"
5050
fi
5151
echo "Hermes commit is $HERMES_TAG_SHA"

.github/workflows/test-all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
else
5656
echo "Hermes Version file not found!!!"
5757
echo "Using the last commit from main for the build:"
58-
HERMES_TAG_SHA=$(git ls-remote https://github.com/$GITHUB_REPOSITORY main | cut -f 1 | tr -d '[:space:]')
58+
HERMES_TAG_SHA=$(git ls-remote https://github.com/facebook/hermes main | cut -f 1 | tr -d '[:space:]')
5959
echo "VERSION=$HERMES_TAG_SHA" >> "$GITHUB_OUTPUT"
6060
fi
6161
echo "Hermes commit is $HERMES_TAG_SHA"

0 commit comments

Comments
 (0)