Skip to content

Commit a272e8e

Browse files
cortinicofacebook-github-bot
authored andcommitted
Remove unused rn-tester e2e tests (facebook#45032)
Summary: Pull Request resolved: facebook#45032 Those tests haven't been running since ~1 year now. I know it's not ideal but I'd rather remove them instead of keeping them around not executing. We can still revert them back from the history once we decide to revive the E2E testing effort. Changelog: [Internal] [Changed] - Remove unused rn-tester e2e tests Reviewed By: cipolleschi Differential Revision: D58729123 fbshipit-source-id: f0f47e3c2e087141fdff506b7c5c9b460263721b
1 parent cdab537 commit a272e8e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+22
-3349
lines changed

.circleci/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ These workflows are:
6363
* `testAll.yml` => runs all the possible tests. This workflow is executed on main and on PRs which change set touches both iOS and Android
6464
* `testAndroid.yml` => runs all the build steps and Android tests. This is used on changes that happens on the Android codebase and infra (`ReactAndroid` folder)
6565
* `testIOS.yml` => runs all the build steps and iOS tests. This is used on changes that happens on the iOS codebase and infra (`React` folder)
66-
* `testE2E.yml` => runs the E2E tests. As of today, E2E tests can be triggered if the commit message contains the `#run-e2e-tests` tag.
6766
* `testJS.yml` => For all the changes that do not touch native/platform code, we only run JS tests.
6867

6968
Notice that if there are changes on files that do not represents code (for example `.md` files like this one or the `Changelog`) we don't run any CI.

.circleci/configurations/jobs.yml

Lines changed: 0 additions & 134 deletions
Original file line numberDiff line numberDiff line change
@@ -107,140 +107,6 @@ jobs:
107107
- store_test_results:
108108
path: ./reports/junit
109109

110-
# -------------------------
111-
# JOBS: iOS E2E Tests
112-
# -------------------------
113-
test_e2e_ios:
114-
executor: reactnativeios
115-
parameters:
116-
ruby_version:
117-
default: "2.7.8"
118-
description: The version of ruby that must be used
119-
type: string
120-
steps:
121-
- checkout_code_with_cache
122-
- run_yarn
123-
- setup_hermes_version
124-
- run:
125-
name: Install appium
126-
command: npm install [email protected] -g
127-
- run:
128-
name: Install appium drivers
129-
command: |
130-
appium driver install uiautomator2
131-
appium driver install xcuitest
132-
- run:
133-
name: Start Appium server
134-
command: appium --base-path /wd/hub
135-
background: true
136-
- run:
137-
name: Start Metro
138-
command: |
139-
cd packages/rn-tester
140-
yarn start
141-
background: true
142-
- brew_install:
143-
package: cmake
144-
- setup_ruby:
145-
ruby_version: << parameters.ruby_version >>
146-
- run:
147-
name: Boot iOS Simulator
148-
command: source scripts/.tests.env && xcrun simctl boot "$IOS_DEVICE" || true
149-
- with_xcodebuild_cache:
150-
steps:
151-
- run:
152-
name: Install Bundler
153-
command: |
154-
cd packages/rn-tester
155-
bundle check || bundle install
156-
bundle exec pod setup
157-
RCT_NEW_ARCH_ENABLED=1 bundle exec pod install --verbose
158-
- run:
159-
name: Build app
160-
command: |
161-
xcodebuild build \
162-
-workspace packages/rn-tester/RNTesterPods.xcworkspace \
163-
-configuration Debug \
164-
-scheme RNTester \
165-
-sdk iphonesimulator \
166-
-derivedDataPath /tmp/e2e/
167-
- run:
168-
name: Move app to correct directory
169-
command: mv /tmp/e2e/Build/Products/Debug-iphonesimulator/RNTester.app packages/rn-tester-e2e/apps/rn-tester.app
170-
- run:
171-
name: Check Appium server status
172-
command: scripts/circleci/check_appium_server_status.sh
173-
- run:
174-
name: Run E2E tests
175-
no_output_timeout: 30m
176-
command: |
177-
cd packages/rn-tester-e2e
178-
(yarn test-e2e ios 2>&1 | tee /tmp/test_log) || true
179-
- store_artifacts:
180-
path: /tmp/test_log
181-
182-
# -------------------------
183-
# JOBS: Android E2E Tests
184-
# -------------------------
185-
test_e2e_android:
186-
executor:
187-
name: android/android-machine
188-
tag: 2023.07.1
189-
steps:
190-
- checkout_code_with_cache
191-
- run_yarn
192-
- android/create-avd:
193-
avd-name: e2e_emulator
194-
system-image: system-images;android-34;google_apis;x86_64
195-
install: true
196-
- android/start-emulator:
197-
avd-name: e2e_emulator
198-
no-window: true
199-
restore-gradle-cache-prefix: v1a
200-
post-emulator-launch-assemble-command: ""
201-
- run:
202-
name: Install appium
203-
command: npm install [email protected] -g
204-
- run:
205-
name: Install appium drivers
206-
command: |
207-
appium driver install [email protected]
208-
appium driver install [email protected]
209-
- run:
210-
name: Start Appium server
211-
command: appium --base-path /wd/hub
212-
background: true
213-
- run:
214-
name: Start Metro
215-
command: |
216-
cd packages/rn-tester
217-
yarn start
218-
background: true
219-
- with_gradle_cache:
220-
steps:
221-
- run:
222-
name: Build app
223-
command: |
224-
./gradlew :packages:rn-tester:android:app:assembleHermesDebug -PreactNativeArchitectures=x86_64
225-
- run:
226-
name: Move app to correct directory
227-
command: mv packages/rn-tester/android/app/build/outputs/apk/hermes/debug/app-hermes-x86_64-debug.apk packages/rn-tester-e2e/apps/rn-tester.apk
228-
- run:
229-
name: Check Appium server status
230-
command: |
231-
if ! nc -z 127.0.0.1 4723; then
232-
echo Could not find Appium server
233-
exit 1
234-
fi
235-
- run:
236-
name: Run E2E tests
237-
no_output_timeout: 30m
238-
command: |
239-
cd packages/rn-tester-e2e
240-
(yarn test-e2e android 2>&1 | tee /tmp/test_log) || true
241-
- store_artifacts:
242-
path: /tmp/test_log
243-
244110
# -------------------------
245111
# JOBS: Build Android
246112
# -------------------------

.circleci/configurations/test_workflows/testE2E.yml

Lines changed: 0 additions & 9 deletions
This file was deleted.

.github/workflows/run-e2e-tests.yml

Lines changed: 0 additions & 26 deletions
This file was deleted.

.gitignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,5 @@ vendor/
159159
# Temporary files created by Metro to check the health of the file watcher
160160
.metro-health-check*
161161

162-
# E2E files
163-
/packages/rn-tester-e2e/apps/*.apk
164-
/packages/rn-tester-e2e/apps/*.app
165-
166162
# CircleCI
167163
.circleci/generated_config.yml

jest.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ module.exports = {
3333
'<rootDir>/packages/react-native/template',
3434
'<rootDir>/packages/react-native/sdks',
3535
'<rootDir>/packages/react-native/Libraries/Renderer',
36-
'<rootDir>/packages/rn-tester/e2e',
3736
'<rootDir>/packages/react-native-test-renderer/src',
3837
],
3938
transformIgnorePatterns: ['node_modules/(?!@react-native/)'],

packages/rn-tester-e2e/README.md

Lines changed: 0 additions & 124 deletions
This file was deleted.

packages/rn-tester-e2e/apps/README.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/rn-tester-e2e/babel.config.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)