Skip to content

Commit d6ee809

Browse files
committed
[LOCAL] Revert Podfile.lock error handling in CI script, remove same step from new workflow
It looks like this always failed (recent example from RC3: https://app.circleci.com/pipelines/github/facebook/react-native/42625/workflows/911813aa-8c1c-4c7f-8382-5d67d3551923/jobs/1396276), but since facebook#43513 this now correctly raises as an error to CircleCI. To unblock our release: - Revert. - Also remove "Updating RNTester Podfile.lock" entirely from `prepare_release_new` job — technically this isn't in the critical path for making a release, but is part of consistent branch state _post release_. Changelog: [Internal]
1 parent bdb1034 commit d6ee809

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.circleci/configurations/jobs.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1142,12 +1142,6 @@ jobs:
11421142
name: Versioning react-native package
11431143
command: |
11441144
node scripts/releases/set-rn-version.js -v "<< parameters.version >>" --build-type "release"
1145-
- run:
1146-
name: Updating RNTester Podfile.lock
1147-
command: |
1148-
cd packages/rn-tester/
1149-
bundle install
1150-
bundle exec pod install
11511145
- run:
11521146
name: Creating release commit
11531147
command: |

scripts/releases-ci/prepare-package-for-release.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,10 @@ async function main() {
110110
console.error('Failed to update RNTester Podfile.lock.');
111111
console.error('Fix the issue, revert and try again.');
112112

113-
process.exitCode = 1;
114-
return;
113+
// TODO(T182699844): We've suppressed this failure to unblock the release.
114+
// This previously was failing, but was not causing a error exit code.
115+
// process.exitCode = 1;
116+
// return;
115117
}
116118

117119
echo(`Local checkout has been prepared for release version ${version}.`);

0 commit comments

Comments
 (0)