Skip to content

Commit e7d1708

Browse files
cortinicofacebook-github-bot
authored andcommitted
Fix broken unableToAddHandledRootView (facebook#45101)
Summary: Pull Request resolved: facebook#45101 This test broke after I merged facebook#34785 yesterday. Just fixing it in a similar way as the test above. Changelog: [Internal] [Changed] - Fix broken unableToAddHandledRootView Reviewed By: rubennorte, blakef Differential Revision: D58864166 fbshipit-source-id: 4f48dbfd5238a2811564ce02199af7fc284d39b4
1 parent 15909fa commit e7d1708

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/MountingManagerTest.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import com.facebook.react.bridge.ReactTestHelper.createMockCatalystInstance
1313
import com.facebook.react.fabric.mounting.MountingManager
1414
import com.facebook.react.fabric.mounting.MountingManager.MountItemExecutor
1515
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
16-
import com.facebook.react.uimanager.IllegalViewOperationException
1716
import com.facebook.react.uimanager.ThemedReactContext
1817
import com.facebook.react.uimanager.ViewManager
1918
import com.facebook.react.uimanager.ViewManagerRegistry
@@ -68,11 +67,13 @@ class MountingManagerTest {
6867
mountingManager.startSurface(rootReactTag, themedReactContext, reactRootView)
6968
}
7069

71-
@Test(expected = IllegalViewOperationException::class)
7270
fun unableToAddHandledRootView() {
7371
val reactRootView = ReactRootView(themedReactContext)
7472
reactRootView.id = 1234567
7573
val rootReactTag = nextRootTag++
74+
75+
// As above this is also a SoftException.
76+
// See https://github.com/facebook/react-native/pull/34785 for more context.
7677
mountingManager.startSurface(rootReactTag, themedReactContext, reactRootView)
7778
}
7879
}

0 commit comments

Comments
 (0)