Skip to content

Commit 46330d7

Browse files
authored
feat: include @rspack/react-refresh-plugin with Re.Pack (#810)
* refactor: move react refresh plugin from peerDeps to deps in repack * refactor: dont include refresh plugin when using repack-init * chore: remove react refresh plugin from depdencies in testers * chore: remove duplicated react refresh plugin entry in repack * chore: add changeset
1 parent c467e06 commit 46330d7

File tree

7 files changed

+10
-19
lines changed

7 files changed

+10
-19
lines changed

.changeset/cold-chefs-confess.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@callstack/repack": minor
3+
"@callstack/repack-init": minor
4+
---
5+
6+
Include `@rspack/plugin-react-refresh` with Re.Pack instead of requiring user to install it

apps/tester-app/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
"@react-native/typescript-config": "0.76.1",
3333
"@rsdoctor/rspack-plugin": "^0.4.5",
3434
"@rspack/core": "1.0.8",
35-
"@rspack/plugin-react-refresh": "1.0.0",
3635
"@svgr/webpack": "^8.1.0",
3736
"@swc/helpers": "^0.5.13",
3837
"@types/jest": "^29.5.12",

apps/tester-federation-v2/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
"@react-native-community/cli-platform-android": "15.0.1",
3030
"@rsdoctor/rspack-plugin": "^0.4.5",
3131
"@rspack/core": "1.0.8",
32-
"@rspack/plugin-react-refresh": "1.0.0",
3332
"@swc/helpers": "^0.5.13",
3433
"@types/jest": "^29.5.12",
3534
"@types/react": "^18.2.51",

apps/tester-federation/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
"@react-native-community/cli-platform-android": "15.0.1",
3737
"@rsdoctor/rspack-plugin": "^0.4.5",
3838
"@rspack/core": "1.0.8",
39-
"@rspack/plugin-react-refresh": "1.0.0",
4039
"@swc/helpers": "^0.5.13",
4140
"@types/jest": "^29.5.12",
4241
"@types/react": "^18.2.51",

packages/init/src/tasks/addDependencies.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import logger from '../utils/logger.js';
88

99
const rspackDependencies = [
1010
'@rspack/core@1.0.3', // 1.0.4 breaks sourcemaps
11-
'@rspack/plugin-react-refresh',
1211
'babel-loader', // still needed for codegen
1312
'@swc/helpers',
1413
'@callstack/repack',
@@ -18,7 +17,6 @@ const webpackDependencies = [
1817
'webpack',
1918
'terser-webpack-plugin',
2019
'babel-loader',
21-
'@rspack/plugin-react-refresh',
2220
'@callstack/repack',
2321
];
2422

packages/repack/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
"@react-native-community/cli": "*",
6161
"@react-native-community/cli-types": "*",
6262
"@rspack/core": ">=1",
63-
"@rspack/plugin-react-refresh": ">=1",
6463
"react-native": ">=0.74",
6564
"webpack": ">=5.90"
6665
},
@@ -78,6 +77,7 @@
7877
"dependencies": {
7978
"@callstack/repack-dev-server": "workspace:*",
8079
"@discoveryjs/json-ext": "^0.5.7",
80+
"@rspack/plugin-react-refresh": "1.0.0",
8181
"colorette": "^2.0.20",
8282
"dedent": "^0.7.0",
8383
"events": "^3.3.0",
@@ -103,7 +103,6 @@
103103
"@module-federation/enhanced": "0.6.10",
104104
"@module-federation/sdk": "0.6.10",
105105
"@rspack/core": "1.0.8",
106-
"@rspack/plugin-react-refresh": "1.0.0",
107106
"@swc/helpers": "0.5.13",
108107
"@types/dedent": "^0.7.0",
109108
"@types/jest": "^29.5.12",

pnpm-lock.yaml

Lines changed: 3 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)