fix: add react-native to byDependency (#1185)

Co-authored-by: Jakub Romańczyk <lorczyslav@gmail.com>
Co-authored-by: Jakub Romanczyk <jakub.romanczyk@callstack.com>

Author: tringenbach

.changeset/better-views-stay.md

@@ -0,0 +1,5 @@
+---
+"@callstack/repack": patch
+---
+
+Resolve `react-native` package exports condition before `import` or `require`

packages/repack/src/utils/getResolveOptions.ts

@@ -115,8 +115,8 @@ export function getResolveOptions(
    * and they need condition names to be defined.
    */
   const byDependency = {
-    esm: { conditionNames: ['import'] },
-    commonjs: { conditionNames: ['require'] },
+    esm: { conditionNames: ['react-native', 'import'] },
+    commonjs: { conditionNames: ['react-native', 'require'] },
   };
 
   /**

tests/metro-compat/resolver/resolve.ts

@@ -149,13 +149,9 @@ export function resolve(
   // this is equivalent to "byDependency" configuration in rspack/webpack
   // enhanced-resolve does not use "byDependency" configuration
   if (metroContext.isESMImport) {
-    resolveOptions.conditionNames?.push(
-      ...resolutionPreset.byDependency.esm.conditionNames
-    );
+    resolveOptions.conditionNames?.push('import');
   } else {
-    resolveOptions.conditionNames?.push(
-      ...resolutionPreset.byDependency.commonjs.conditionNames
-    );
+    resolveOptions.conditionNames?.push('require');
   }
 
   const resolve = enhancedResolve.create.sync(resolveOptions);

tests/resolver-cases/src/__tests__/exports-resolution.test.ts

@@ -2,31 +2,25 @@ import { describe, expect, test } from 'vitest';
 import { setupTestEnvironment } from '../test-helpers.js';
 
 describe('Package Exports Resolution', () => {
-  test.fails(
-    'should resolve ESM imports with react-native condition',
-    async () => {
-      const { resolve } = await setupTestEnvironment(['exports'], {
-        platform: 'ios',
-        enablePackageExports: true,
-      });
+  test('should resolve ESM imports with react-native condition', async () => {
+    const { resolve } = await setupTestEnvironment(['exports'], {
+      platform: 'ios',
+      enablePackageExports: true,
+    });
 
-      const result = await resolve('complex-lib', 'esm');
-      expect(result).toBe('/node_modules/complex-lib/esm/index.native.js');
-    }
-  );
+    const result = await resolve('complex-lib', 'esm');
+    expect(result).toBe('/node_modules/complex-lib/esm/index.native.js');
+  });
 
-  test.fails(
-    'should resolve CommonJS requires with react-native condition',
-    async () => {
-      const { resolve } = await setupTestEnvironment(['exports'], {
-        platform: 'ios',
-        enablePackageExports: true,
-      });
+  test('should resolve CommonJS requires with react-native condition', async () => {
+    const { resolve } = await setupTestEnvironment(['exports'], {
+      platform: 'ios',
+      enablePackageExports: true,
+    });
 
-      const result = await resolve('complex-lib', 'cjs');
-      expect(result).toBe('/node_modules/complex-lib/cjs/index.native.js');
-    }
-  );
+    const result = await resolve('complex-lib', 'cjs');
+    expect(result).toBe('/node_modules/complex-lib/cjs/index.native.js');
+  });
 
   test('should resolve utils subpath', async () => {
     const { resolve } = await setupTestEnvironment(['exports'], {
@@ -51,25 +45,22 @@ describe('Package Exports Resolution', () => {
     expect(result).toBe('/node_modules/complex-lib/native-specific.js');
   });
 
-  test.fails(
-    'should resolve to native version for react-native condition',
-    async () => {
-      const { resolve } = await setupTestEnvironment(['react-strict-dom'], {
-        platform: 'ios',
-        enablePackageExports: true,
-      });
+  test('should resolve to native version for react-native condition', async () => {
+    const { resolve } = await setupTestEnvironment(['react-strict-dom'], {
+      platform: 'ios',
+      enablePackageExports: true,
+    });
 
-      const esmResult = await resolve('react-strict-dom', 'esm');
-      expect(esmResult).toBe(
-        '/node_modules/react-strict-dom/dist/native/index.js'
-      );
+    const esmResult = await resolve('react-strict-dom', 'esm');
+    expect(esmResult).toBe(
+      '/node_modules/react-strict-dom/dist/native/index.js'
+    );
 
-      const cjsResult = await resolve('react-strict-dom', 'cjs');
-      expect(cjsResult).toBe(
-        '/node_modules/react-strict-dom/dist/native/index.js'
-      );
-    }
-  );
+    const cjsResult = await resolve('react-strict-dom', 'cjs');
+    expect(cjsResult).toBe(
+      '/node_modules/react-strict-dom/dist/native/index.js'
+    );
+  });
 
   test('should fail to resolve with package exports disabled', async () => {
     const { resolve } = await setupTestEnvironment(['react-strict-dom'], {