Skip to content

Commit c53900d

Browse files
authored
fix: REPACK_VERBOSE env not affecting dev server logs (#1246)
1 parent b690044 commit c53900d

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

.changeset/little-turkeys-go.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@callstack/repack": patch
3+
---
4+
5+
Fix `REPACK_VERBOSE` not affecting dev server logs

packages/repack/src/commands/rspack/start.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { Configuration } from '@rspack/core';
22
import packageJson from '../../../package.json';
3-
import { CLIError } from '../../helpers/index.js';
3+
import { VERBOSE_ENV_KEY } from '../../env.js';
4+
import { CLIError, isTruthyEnv } from '../../helpers/index.js';
45
import {
56
ConsoleReporter,
67
FileReporter,
@@ -57,15 +58,16 @@ export async function start(
5758
// expose selected args as environment variables
5859
setupEnvironment(args);
5960

61+
const isVerbose = isTruthyEnv(process.env[VERBOSE_ENV_KEY]);
6062
const devServerOptions = configs[0].devServer ?? {};
61-
const showHttpRequests = args.verbose || args.logRequests;
63+
const showHttpRequests = isVerbose || args.logRequests;
6264

6365
// dynamically import dev middleware to match version of react-native
6466
const devMiddleware = await getDevMiddleware(cliConfig.reactNativePath);
6567

6668
const reporter = composeReporters(
6769
[
68-
new ConsoleReporter({ asJson: args.json, isVerbose: args.verbose }),
70+
new ConsoleReporter({ asJson: args.json, isVerbose: isVerbose }),
6971
args.logFile ? new FileReporter({ filename: args.logFile }) : undefined,
7072
].filter(Boolean) as Reporter[]
7173
);

packages/repack/src/commands/webpack/start.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import type { Server } from '@callstack/repack-dev-server';
22
import type { Configuration, StatsCompilation } from 'webpack';
33
import packageJson from '../../../package.json';
4-
import { CLIError } from '../../helpers/index.js';
4+
import { VERBOSE_ENV_KEY } from '../../env.js';
5+
import { CLIError, isTruthyEnv } from '../../helpers/index.js';
56
import {
67
ConsoleReporter,
78
FileReporter,
@@ -59,15 +60,16 @@ export async function start(
5960
// expose selected args as environment variables
6061
setupEnvironment(args);
6162

63+
const isVerbose = isTruthyEnv(process.env[VERBOSE_ENV_KEY]);
6264
const devServerOptions = configs[0].devServer ?? {};
63-
const showHttpRequests = args.verbose || args.logRequests;
65+
const showHttpRequests = isVerbose || args.logRequests;
6466

6567
// dynamically import dev middleware to match version of react-native
6668
const devMiddleware = await getDevMiddleware(cliConfig.reactNativePath);
6769

6870
const reporter = composeReporters(
6971
[
70-
new ConsoleReporter({ asJson: args.json, isVerbose: args.verbose }),
72+
new ConsoleReporter({ asJson: args.json, isVerbose: isVerbose }),
7173
args.logFile ? new FileReporter({ filename: args.logFile }) : undefined,
7274
].filter(Boolean) as Reporter[]
7375
);

0 commit comments

Comments
 (0)