Skip to content

Commit 0dd2d6d

Browse files
committed
Use the include(${WEAK_NODE_API_CONFIG}) syntax in our own tests
1 parent 37f2069 commit 0dd2d6d

File tree

2 files changed

+10
-24
lines changed

2 files changed

+10
-24
lines changed
Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
1-
cmake_minimum_required(VERSION 3.15)
1+
cmake_minimum_required(VERSION 3.15...3.31)
22
project(tests-async)
33

4-
add_compile_definitions(NAPI_VERSION=8)
4+
include(${WEAK_NODE_API_CONFIG})
55

6-
add_library(addon SHARED addon.c ${CMAKE_JS_SRC})
7-
set_target_properties(addon PROPERTIES PREFIX "" SUFFIX ".node")
8-
target_include_directories(addon PRIVATE ${CMAKE_JS_INC})
9-
target_link_libraries(addon PRIVATE ${CMAKE_JS_LIB})
10-
target_compile_features(addon PRIVATE cxx_std_17)
11-
12-
if(MSVC AND CMAKE_JS_NODELIB_DEF AND CMAKE_JS_NODELIB_TARGET)
13-
# Generate node.lib
14-
execute_process(COMMAND ${CMAKE_AR} /def:${CMAKE_JS_NODELIB_DEF} /out:${CMAKE_JS_NODELIB_TARGET} ${CMAKE_STATIC_LINKER_FLAGS})
15-
endif()
6+
add_library(addon SHARED addon.c)
7+
target_link_libraries(addon PRIVATE weak-node-api)
8+
target_compile_features(addon PRIVATE cxx_std_20)
Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
1-
cmake_minimum_required(VERSION 3.15)
1+
cmake_minimum_required(VERSION 3.15...3.31)
22
project(tests-buffers)
33

4-
add_compile_definitions(NAPI_VERSION=8)
4+
include(${WEAK_NODE_API_CONFIG})
55

6-
add_library(addon SHARED addon.c ${CMAKE_JS_SRC})
7-
set_target_properties(addon PROPERTIES PREFIX "" SUFFIX ".node")
8-
target_include_directories(addon PRIVATE ${CMAKE_JS_INC})
9-
target_link_libraries(addon PRIVATE ${CMAKE_JS_LIB})
10-
target_compile_features(addon PRIVATE cxx_std_17)
11-
12-
if(MSVC AND CMAKE_JS_NODELIB_DEF AND CMAKE_JS_NODELIB_TARGET)
13-
# Generate node.lib
14-
execute_process(COMMAND ${CMAKE_AR} /def:${CMAKE_JS_NODELIB_DEF} /out:${CMAKE_JS_NODELIB_TARGET} ${CMAKE_STATIC_LINKER_FLAGS})
15-
endif()
6+
add_library(addon SHARED addon.c)
7+
target_link_libraries(addon PRIVATE weak-node-api)
8+
target_compile_features(addon PRIVATE cxx_std_20)

0 commit comments

Comments
 (0)