Skip to content

Commit 33b8104

Browse files
committed
Incorporate review
1 parent 4e5a9af commit 33b8104

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

packages/cmake-rn/src/platforms/android.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const platform: Platform<Triplet[], AndroidOpts> = {
102102
],
103103
defaultTriplets(purpose) {
104104
if (purpose === "release") {
105-
return this.triplets;
105+
return [...this.triplets];
106106
} else if (process.arch === "arm64") {
107107
return ["aarch64-linux-android"];
108108
} else if (process.arch === "x64") {

packages/cmake-rn/src/platforms/apple.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,8 @@ export const platform: Platform<Triplet[], AppleOpts> = {
224224
"arm64-apple-visionos",
225225
"arm64;x86_64-apple-visionos-sim",
226226
];
227-
} else if (process.arch === "arm64") {
228-
return ["arm64-apple-ios-sim"];
229-
} else if (process.arch === "x64") {
230-
return ["x86_64-apple-ios-sim"];
231227
} else {
232-
return [];
228+
return ["arm64;x86_64-apple-ios-sim"];
233229
}
234230
},
235231
amendCommand(command) {

packages/cmake-rn/src/platforms/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export type Platform<
5353
*/
5454
defaultTriplets(
5555
purpose: "development" | "release",
56-
): Readonly<Triplets> | Promise<Readonly<Triplets>>;
56+
): Triplet[] | Promise<Triplet[]>;
5757
/**
5858
* Implement this to add any platform specific options to the command.
5959
*/

0 commit comments

Comments
 (0)