Tread a failing opendir as an empty dir

Author: kraenhansen

packages/host/src/node/path-utils.test.ts

@@ -367,6 +367,23 @@ describe("findNodeApiModulePaths", () => {
       path.join(tempDir, "node_modules/root.apple.node"),
     ]);
   });
+
+  it("returns empty when directory cannot be read due to permissions", async (context) => {
+    const tempDir = setupTempDirectory(context, {
+      "addon.apple.node/react-native-node-api-module": "",
+    });
+
+    removeReadPermissions(tempDir);
+    try {
+      const result = findNodeApiModulePaths({
+        fromPath: tempDir,
+        platform: "apple",
+      });
+      assert.deepEqual(await result, []);
+    } finally {
+      restoreReadPermissions(tempDir);
+    }
+  });
 });
 
 describe("determineModuleContext", () => {

packages/host/src/node/path-utils.ts

@@ -327,20 +327,24 @@ export async function findNodeApiModulePaths(
   const result: string[] = [];
   const pendingResults: Promise<string[]>[] = [];
 
-  for await (const dirent of await fs.promises.opendir(candidatePath)) {
-    if (
-      dirent.isFile() &&
-      dirent.name === MAGIC_FILENAME &&
-      hasPlatformExtension(platform, candidatePath)
-    ) {
-      result.push(candidatePath);
-    } else if (dirent.isDirectory()) {
-      // Traverse into the child directory
-      // Pushing result into a list instead of awaiting immediately to parallelize the search
-      pendingResults.push(
-        findNodeApiModulePaths(options, path.join(suffix, dirent.name))
-      );
+  try {
+    for await (const dirent of await fs.promises.opendir(candidatePath)) {
+      if (
+        dirent.isFile() &&
+        dirent.name === MAGIC_FILENAME &&
+        hasPlatformExtension(platform, candidatePath)
+      ) {
+        result.push(candidatePath);
+      } else if (dirent.isDirectory()) {
+        // Traverse into the child directory
+        // Pushing result into a list instead of awaiting immediately to parallelize the search
+        pendingResults.push(
+          findNodeApiModulePaths(options, path.join(suffix, dirent.name))
+        );
+      }
     }
+  } catch {
+    // Intentionally left empty: if the directory cannot be read, we skip it
   }
   const childResults = await Promise.all(pendingResults);
   result.push(...childResults.flatMap((filePath) => filePath));