Renamed purpose to mode and values to be more semantic

Author: kraenhansen

packages/cmake-rn/src/cli.ts

@@ -187,7 +187,7 @@ program = program.action(
     for (const platform of Object.values(platforms)) {
       // Forcing the types a bit here, since the platform id option is dynamically added
       if ((baseOptions as Record<string, unknown>)[platform.id]) {
-        for (const triplet of await platform.defaultTriplets("release")) {
+        for (const triplet of await platform.defaultTriplets("all")) {
           triplets.add(triplet);
         }
       }
@@ -196,7 +196,9 @@ program = program.action(
     if (triplets.size === 0) {
       for (const platform of Object.values(platforms)) {
         if (platform.isSupportedByHost()) {
-          for (const triplet of await platform.defaultTriplets("development")) {
+          for (const triplet of await platform.defaultTriplets(
+            "current-development",
+          )) {
             triplets.add(triplet);
           }
         }

packages/cmake-rn/src/platforms/android.ts

@@ -100,15 +100,21 @@ export const platform: Platform<Triplet[], AndroidOpts> = {
     "i686-linux-android",
     "x86_64-linux-android",
   ],
-  defaultTriplets(purpose) {
-    if (purpose === "release") {
+  defaultTriplets(mode) {
+    if (mode === "all") {
       return [...this.triplets];
-    } else if (process.arch === "arm64") {
-      return ["aarch64-linux-android"];
-    } else if (process.arch === "x64") {
-      return ["x86_64-linux-android"];
+    } else if (mode === "current-development") {
+      // We're applying a heuristic to determine the current simulators
+      // TODO: Run a command to probe the currently running emulators instead
+      if (process.arch === "arm64") {
+        return ["aarch64-linux-android"];
+      } else if (process.arch === "x64") {
+        return ["x86_64-linux-android"];
+      } else {
+        return [];
+      }
     } else {
-      return [];
+      throw new Error(`Unexpected mode: ${mode as string}`);
     }
   },
   amendCommand(command) {

packages/cmake-rn/src/platforms/apple.ts

@@ -210,8 +210,8 @@ export const platform: Platform<Triplet[], AppleOpts> = {
     "arm64-apple-visionos-sim",
     "arm64;x86_64-apple-visionos-sim",
   ],
-  defaultTriplets(purpose) {
-    if (purpose === "release") {
+  defaultTriplets(mode) {
+    if (mode === "all") {
       return [
         "arm64;x86_64-apple-darwin",
 
@@ -224,8 +224,12 @@ export const platform: Platform<Triplet[], AppleOpts> = {
         "arm64-apple-visionos",
         "arm64;x86_64-apple-visionos-sim",
       ];
-    } else {
+    } else if (mode === "current-development") {
+      // We're applying a heuristic to determine the current simulators
+      // TODO: Run a command to probe the currently running simulators instead
       return ["arm64;x86_64-apple-ios-sim"];
+    } else {
+      throw new Error(`Unexpected mode: ${mode as string}`);
     }
   },
   amendCommand(command) {

packages/cmake-rn/src/platforms/types.ts

@@ -49,10 +49,9 @@ export type Platform<
   triplets: Readonly<Triplets>;
   /**
    * Get the limited subset of triplets that should be built by default for this platform.
-   *
    */
   defaultTriplets(
-    purpose: "development" | "release",
+    mode: "current-development" | "all",
   ): Triplet[] | Promise<Triplet[]>;
   /**
    * Implement this to add any platform specific options to the command.