Use CMake file API to read shared library target paths

Author: kraenhansen

.changeset/evil-vans-love.md

@@ -0,0 +1,5 @@
+---
+"cmake-rn": patch
+---
+
+Use CMake file API to read shared library target paths

package-lock.json

@@ -23,6 +23,7 @@
   },
   "dependencies": {
     "@react-native-node-api/cli-utils": "0.1.0",
+    "cmake-file-api": "0.1.0",
     "react-native-node-api": "0.5.1"
   },
   "peerDependencies": {

packages/cmake-rn/package.json

@@ -13,6 +13,7 @@ import {
   wrapAction,
 } from "@react-native-node-api/cli-utils";
 import { isSupportedTriplet } from "react-native-node-api";
+import * as cmakeFileApi from "cmake-file-api";
 
 import {
   getCmakeJSVariables,
@@ -327,6 +328,8 @@ async function configureProject<T extends string>(
     { CMAKE_LIBRARY_OUTPUT_DIRECTORY: outputPath },
   ];
 
+  await cmakeFileApi.createSharedStatelessQuery(buildPath, "codemodel", "2");
+
   await spawn(
     "cmake",
     [

packages/cmake-rn/src/cli.ts

@@ -8,6 +8,7 @@ import {
   determineAndroidLibsFilename,
   AndroidTriplet as Triplet,
 } from "react-native-node-api";
+import * as cmakeFileApi from "cmake-file-api";
 
 import type { Platform } from "./types.js";
 
@@ -121,28 +122,35 @@ export const platform: Platform<Triplet[], AndroidOpts> = {
     const { ANDROID_HOME } = process.env;
     return typeof ANDROID_HOME === "string" && fs.existsSync(ANDROID_HOME);
   },
-  async postBuild({ outputPath, triplets }, { autoLink }) {
-    // TODO: Include `configuration` in the output path
+  async postBuild({ outputPath, triplets }, { autoLink, configuration }) {
     const libraryPathByTriplet = Object.fromEntries(
       await Promise.all(
-        triplets.map(async ({ triplet, outputPath }) => {
+        triplets.map(async ({ triplet, buildPath }) => {
           assert(
-            fs.existsSync(outputPath),
-            `Expected a directory at ${outputPath}`,
+            fs.existsSync(buildPath),
+            `Expected a directory at ${buildPath}`,
           );
-          // Expect binary file(s), either .node or .so
-          const dirents = await fs.promises.readdir(outputPath, {
-            withFileTypes: true,
-          });
-          const result = dirents
-            .filter(
-              (dirent) =>
-                dirent.isFile() &&
-                (dirent.name.endsWith(".so") || dirent.name.endsWith(".node")),
-            )
-            .map((dirent) => path.join(dirent.parentPath, dirent.name));
-          assert.equal(result.length, 1, "Expected exactly one library file");
-          return [triplet, result[0]] as const;
+          const targets = await cmakeFileApi.readCurrentTargetsDeep(
+            buildPath,
+            configuration,
+            "2.0",
+          );
+          const sharedLibraries = targets.filter(
+            (target) => target.type === "SHARED_LIBRARY",
+          );
+          assert.equal(
+            sharedLibraries.length,
+            1,
+            "Expected exactly one shared library",
+          );
+          const [sharedLibrary] = sharedLibraries;
+          const { artifacts } = sharedLibrary;
+          assert(
+            artifacts && artifacts.length,
+            "Expected exactly one artifact",
+          );
+          const [artifact] = artifacts;
+          return [triplet, path.join(buildPath, artifact.path)] as const;
         }),
       ),
     ) as Record<Triplet, string>;

packages/cmake-rn/src/platforms/android.ts

@@ -11,6 +11,7 @@ import {
 } from "react-native-node-api";
 
 import type { Platform } from "./types.js";
+import * as cmakeFileApi from "cmake-file-api";
 
 type XcodeSDKName =
   | "iphoneos"
@@ -136,31 +137,29 @@ export const platform: Platform<Triplet[], AppleOpts> = {
     { configuration, autoLink, xcframeworkExtension },
   ) {
     const libraryPaths = await Promise.all(
-      triplets.map(async ({ outputPath }) => {
-        const configSpecificPath = path.join(outputPath, configuration);
+      triplets.map(async ({ buildPath }) => {
         assert(
-          fs.existsSync(configSpecificPath),
-          `Expected a directory at ${configSpecificPath}`,
+          fs.existsSync(buildPath),
+          `Expected a directory at ${buildPath}`,
         );
-        // Expect binary file(s), either .node or .dylib
-        const files = await fs.promises.readdir(configSpecificPath);
-        const result = files.map(async (file) => {
-          const filePath = path.join(configSpecificPath, file);
-          if (filePath.endsWith(".dylib")) {
-            return filePath;
-          } else if (file.endsWith(".node")) {
-            // Rename the file to .dylib for xcodebuild to accept it
-            const newFilePath = filePath.replace(/\.node$/, ".dylib");
-            await fs.promises.rename(filePath, newFilePath);
-            return newFilePath;
-          } else {
-            throw new Error(
-              `Expected a .node or .dylib file, but found ${file}`,
-            );
-          }
-        });
-        assert.equal(result.length, 1, "Expected exactly one library file");
-        return await result[0];
+        const targets = await cmakeFileApi.readCurrentTargetsDeep(
+          buildPath,
+          configuration,
+          "2.0",
+        );
+        const sharedLibraries = targets.filter(
+          (target) => target.type === "SHARED_LIBRARY",
+        );
+        assert.equal(
+          sharedLibraries.length,
+          1,
+          "Expected exactly one shared library",
+        );
+        const [sharedLibrary] = sharedLibraries;
+        const { artifacts } = sharedLibrary;
+        assert(artifacts && artifacts.length, "Expected exactly one artifact");
+        const [artifact] = artifacts;
+        return path.join(buildPath, artifact.path);
       }),
     );
     const frameworkPaths = libraryPaths.map(createAppleFramework);