Tread a failing opendir as an empty dir

Author: kraenhansen

packages/host/src/node/path-utils.test.ts

@@ -62,9 +62,9 @@ describe("isNodeApiModule", () => {
     assert(isNodeApiModule(path.join(tempDirectoryPath, "addon.node")));
   });
 
-  // there is no way to set ACLs on directories in Node.js on Windows with brittle powershell commands
   it(
     "returns false when directory cannot be read due to permissions",
+    // Skipping on Windows because there is no way to set ACLs on directories in Node.js on Windows without brittle powershell commands
     { skip: process.platform === "win32" },
     (context) => {
       const tempDirectoryPath = setupTempDirectory(context, {
@@ -367,6 +367,28 @@ describe("findNodeApiModulePaths", () => {
       path.join(tempDir, "node_modules/root.apple.node"),
     ]);
   });
+
+  it(
+    "returns empty when directory cannot be read due to permissions",
+    // Skipping on Windows because there is no way to set ACLs on directories in Node.js on Windows without brittle powershell commands
+    { skip: process.platform === "win32" },
+    async (context) => {
+      const tempDir = setupTempDirectory(context, {
+        "addon.apple.node/react-native-node-api-module": "",
+      });
+
+      removeReadPermissions(tempDir);
+      try {
+        const result = findNodeApiModulePaths({
+          fromPath: tempDir,
+          platform: "apple",
+        });
+        assert.deepEqual(await result, []);
+      } finally {
+        restoreReadPermissions(tempDir);
+      }
+    }
+  );
 });
 
 describe("determineModuleContext", () => {

packages/host/src/node/path-utils.ts

@@ -327,20 +327,32 @@ export async function findNodeApiModulePaths(
   const result: string[] = [];
   const pendingResults: Promise<string[]>[] = [];
 
-  for await (const dirent of await fs.promises.opendir(candidatePath)) {
+  try {
+    for await (const dirent of await fs.promises.opendir(candidatePath)) {
+      if (
+        dirent.isFile() &&
+        dirent.name === MAGIC_FILENAME &&
+        hasPlatformExtension(platform, candidatePath)
+      ) {
+        result.push(candidatePath);
+      } else if (dirent.isDirectory()) {
+        // Traverse into the child directory
+        // Pushing result into a list instead of awaiting immediately to parallelize the search
+        pendingResults.push(
+          findNodeApiModulePaths(options, path.join(suffix, dirent.name))
+        );
+      }
+    }
+  } catch (error) {
     if (
-      dirent.isFile() &&
-      dirent.name === MAGIC_FILENAME &&
-      hasPlatformExtension(platform, candidatePath)
+      error instanceof Error &&
+      "code" in error &&
+      (error.code === "ENOENT" || error.code === "EACCES")
     ) {
-      result.push(candidatePath);
-    } else if (dirent.isDirectory()) {
-      // Traverse into the child directory
-      // Pushing result into a list instead of awaiting immediately to parallelize the search
-      pendingResults.push(
-        findNodeApiModulePaths(options, path.join(suffix, dirent.name))
-      );
+      // Gracefully handling issues with reading directories
+      return [];
     }
+    throw error;
   }
   const childResults = await Promise.all(pendingResults);
   result.push(...childResults.flatMap((filePath) => filePath));