Support multiple purposes when picking default triplets

Author: kraenhansen

packages/cmake-rn/src/cli.ts

@@ -187,7 +187,7 @@ program = program.action(
     for (const platform of Object.values(platforms)) {
       // Forcing the types a bit here, since the platform id option is dynamically added
       if ((baseOptions as Record<string, unknown>)[platform.id]) {
-        for (const triplet of platform.triplets) {
+        for (const triplet of await platform.defaultTriplets("release")) {
           triplets.add(triplet);
         }
       }
@@ -196,7 +196,7 @@ program = program.action(
     if (triplets.size === 0) {
       for (const platform of Object.values(platforms)) {
         if (platform.isSupportedByHost()) {
-          for (const triplet of await platform.defaultTriplets()) {
+          for (const triplet of await platform.defaultTriplets("development")) {
             triplets.add(triplet);
           }
         }

packages/cmake-rn/src/platforms/android.ts

@@ -100,8 +100,10 @@ export const platform: Platform<Triplet[], AndroidOpts> = {
     "i686-linux-android",
     "x86_64-linux-android",
   ],
-  defaultTriplets() {
-    if (process.arch === "arm64") {
+  defaultTriplets(purpose) {
+    if (purpose === "release") {
+      return this.triplets;
+    } else if (process.arch === "arm64") {
       return ["aarch64-linux-android"];
     } else if (process.arch === "x64") {
       return ["x86_64-linux-android"];

packages/cmake-rn/src/platforms/apple.ts

@@ -210,8 +210,27 @@ export const platform: Platform<Triplet[], AppleOpts> = {
     "arm64-apple-visionos-sim",
     "arm64;x86_64-apple-visionos-sim",
   ],
-  defaultTriplets() {
-    return process.arch === "arm64" ? ["arm64-apple-ios-sim"] : [];
+  defaultTriplets(purpose) {
+    if (purpose === "release") {
+      return [
+        "arm64;x86_64-apple-darwin",
+
+        "arm64-apple-ios",
+        "arm64;x86_64-apple-ios-sim",
+
+        "arm64-apple-tvos",
+        "arm64;x86_64-apple-tvos-sim",
+
+        "arm64-apple-visionos",
+        "arm64;x86_64-apple-visionos-sim",
+      ];
+    } else if (process.arch === "arm64") {
+      return ["arm64-apple-ios-sim"];
+    } else if (process.arch === "x64") {
+      return ["x86_64-apple-ios-sim"];
+    } else {
+      return [];
+    }
   },
   amendCommand(command) {
     return command.addOption(xcframeworkExtensionOption);

packages/cmake-rn/src/platforms/types.ts

@@ -33,6 +33,7 @@ export type Platform<
   Triplets extends string[] = string[],
   Opts extends cli.OptionValues = Record<string, unknown>,
   Command = ExtendedCommand<Opts>,
+  Triplet extends string = Triplets[number],
 > = {
   /**
    * Used to identify the platform in the CLI.
@@ -47,9 +48,12 @@ export type Platform<
    */
   triplets: Readonly<Triplets>;
   /**
-   * Get the limited subset of triplets that should be built by default for this platform, to support a development workflow.
+   * Get the limited subset of triplets that should be built by default for this platform.
+   *
    */
-  defaultTriplets(): Triplets[number][] | Promise<Triplets[number][]>;
+  defaultTriplets(
+    purpose: "development" | "release",
+  ): Readonly<Triplets> | Promise<Readonly<Triplets>>;
   /**
    * Implement this to add any platform specific options to the command.
    */
@@ -62,15 +66,15 @@ export type Platform<
    * Configure all projects for this platform.
    */
   configure(
-    triplets: TripletContext<Triplets[number]>[],
+    triplets: TripletContext<Triplet>[],
     options: BaseOpts & Opts,
     spawn: Spawn,
   ): Promise<void>;
   /**
    * Platform specific command to build a triplet project.
    */
   build(
-    context: TripletContext<Triplets[number]>,
+    context: TripletContext<Triplet>,
     options: BaseOpts & Opts,
   ): Promise<void>;
   /**
@@ -81,7 +85,7 @@ export type Platform<
      * Location of the final prebuilt artefact.
      */
     outputPath: string,
-    triplets: TripletContext<Triplets[number]>[],
+    triplets: TripletContext<Triplet>[],
     options: BaseOpts & Opts,
   ): Promise<void>;
 };