Skip to content

Commit e655d71

Browse files
committed
Merge remote-tracking branch 'upstream/main' into replace-package-manager
2 parents 7347f21 + 172ca06 commit e655d71

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+989
-579
lines changed

.changeset/fresh-nails-repair.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
"gyp-to-cmake": patch
3+
"cmake-rn": patch
4+
"ferric-cli": patch
5+
"react-native-node-api": patch
6+
---
7+
8+
Refactored CLIs to use a shared utility package

.changeset/red-candles-sell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"react-native-node-api": patch
3+
---
4+
5+
Move REACT_NATIVE_OVERRIDE_HERMES_DIR out of tasks to fail earlier

.changeset/rotten-melons-brush.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"cmake-rn": minor
3+
---
4+
5+
Breaking: Renamed --target to --triplet to free up --target for passing CMake targets

.changeset/salty-kiwis-turn.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"cmake-rn": patch
3+
---
4+
5+
Pretty print spawn errors instead of simply rethrowing to commander.

.changeset/shaggy-dots-deny.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"cmake-rn": minor
3+
---
4+
5+
Add passing of definitions (-D) to cmake when configuring

.changeset/social-rivers-tie.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"cmake-rn": patch
3+
---
4+
5+
Assert the existence of CMakeList.txt before passing control to CMake

.changeset/swift-loops-create.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"cmake-rn": minor
3+
---
4+
5+
Pass --target to CMake

.github/workflows/check.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ name: Check
33
env:
44
# Version here should match the one in React Native template and packages/cmake-rn/src/cli.ts
55
NDK_VERSION: 27.1.12297006
6+
# Enabling the Gradle test on CI (disabled by default because it downloads a lot)
7+
ENABLE_GRADLE_TESTS: true
68

79
on:
810
push:
@@ -110,7 +112,7 @@ jobs:
110112
- run: pnpm install --frozen-lockfile
111113
- run: pnpm bootstrap
112114
env:
113-
CMAKE_RN_TARGETS: arm64-apple-ios-sim
115+
CMAKE_RN_TRIPLETS: arm64-apple-ios-sim
114116
FERRIC_TARGETS: aarch64-apple-ios-sim
115117
- run: pnpm pod-install
116118
working-directory: apps/test-app
@@ -146,8 +148,8 @@ jobs:
146148
- run: pnpm install --frozen-lockfile
147149
- run: pnpm bootstrap
148150
env:
149-
CMAKE_RN_TARGETS: i686-linux-android
150-
FERRIC_TARGETS: i686-linux-android
151+
CMAKE_RN_TRIPLETS: x86_64-linux-android
152+
FERRIC_TARGETS: x86_64-linux-android
151153
- name: Clone patched Hermes version
152154
shell: bash
153155
run: |
@@ -180,9 +182,8 @@ jobs:
180182
with:
181183
api-level: 29
182184
force-avd-creation: false
183-
emulator-options: -no-snapshot-save -no-metrics -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
184185
disable-animations: true
185-
arch: x86
186+
arch: x86_64
186187
ndk: ${{ env.NDK_VERSION }}
187188
cmake: 3.22.1
188189
working-directory: apps/test-app

apps/test-app/App.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function loadTests({
7272
it("exports a callable sum function", () => {
7373
const exampleAddon =
7474
/* eslint-disable-next-line @typescript-eslint/no-require-imports -- TODO: Determine why a dynamic import doesn't work on Android */
75-
require("ferric-example") as typeof import("ferric-example");
75+
require("@react-native-node-api/ferric-example") as typeof import("@react-native-node-api/ferric-example");
7676
const result = exampleAddon.sum(1, 3);
7777
if (result !== 4) {
7878
throw new Error(`Expected 1 + 3 to equal 4, but got ${result}`);

apps/test-app/CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
11
# react-native-node-api-test-app
22

3+
## 0.2.0
4+
5+
### Minor Changes
6+
7+
- a0212c8: Add explicit support for React Native 0.81.1 (0.79.6, 0.80.0, 0.80.1, 0.80.2 & 0.81.0)
8+
9+
### Patch Changes
10+
11+
- a0212c8: Renamed ferric-example in test app to match mono-repo packages
12+
- Updated dependencies [a0212c8]
13+
- Updated dependencies [a0212c8]
14+
15+
- @react-native-node-api/node-tests@undefined
16+
- @react-native-node-api/node-addon-examples@undefined
17+
318
## 0.1.2
419

520
### Patch Changes

0 commit comments

Comments
 (0)