Skip to content

Make scanning for auto-linkable files robust to concurrent changes in the fsΒ #185

@kraenhansen

Description

@kraenhansen

We're seeing CI failures related in the Android Gradle task running the Host CLI to scan for Node-API binaries while building:

[android] - Linking Android Node-API modules into auto-linked/android
[android] node:internal/process/promises:394 triggerUncaughtException(err, true /* fromPromise */); ^ [Error: ENOENT: no such file or directory, opendir '/home/runner/work/react-native-node-api/react-native-node-api/node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_15613.dir'] { errno: -2, code: 'ENOENT', syscall: 'opendir', path: '/home/runner/work/react-native-node-api/react-native-node-api/node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_15613.dir'

This was likely provoked by #178 where the recursive function scanning the fs was refactored into using async function calls.

We should make failures a no-op and find ways of filtering out known large directories unlikely to contain prebuilds.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Android πŸ€–Anything related to the Android platform (Gradle, NDK, Android SDK)Linking πŸ”—Discovering and copying prebuilds from packages into the host

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions