SQL in query should support SQL comments

[rsdoiel]

It looks like the held in the YAML config file defining the query gets concatenated into a single string. This means you can't use a SQL comment. The work around is to use a YAML comment but that is not idea. If I have the following for a query it should work.

     -- a SQL select stmt follows
     select count(*) from tms;

It should not be transforms into -- a SQL select stmt follows select count(*) from tms;.

Work around is to use a YAML comment character on the line.

    # -- a SQL select stmt follows
    select count(*) from tms;

[rsdoiel]

There is something about how the query are loaded. Not sure if this is nuance of YAML or something I'm introducing accidentally in the datasetd code. I want to support multi line SQL as this is easier to read and debug.

my_sql_query: |
  -- SQL statement to count things.
  select
    count(*)
  from my_table
  where thing != ''
  order by other_thing;

In this configuration I will get an "Not Acceptable" error in datasetd. The -- comment will be treated as the start of the statement and the newline terminating the comment gets ignored. So then I tried the following.

my_sql_query: |
  # -- SQL statement to count things.
  select
    count(*)
  from my_table
  where thing != ''
  order by other_thing;

This doesn't work because # isn't a valid SQL start of statement. It is being treated as part of the string associated with the my_sql_query attribute in the YAML parse. This makes sense because the | is the YAML to say this is a multi-line string.

This oddly works as a work around.

my_sql_query:
  # -- SQL statement to count things.
  select
    count(*)
  from my_table
  where thing != ''
  order by other_thing;

I this last case YAML parse is treating the comment as a YAML compent AND treating the rest of the statemente as belonging to my_sql_query attribute in the object.

When I display the valuel it shows a multi-line string. Before I form a prepared statement I will need to remove comment lines. I suspect that the SQL library in Go doesn't know how to handle in-line comments correctly.