fix(reactivity): should not recompute if computed does not track reactive data (vuejs#12341)

close vuejs#12337

Author: edison1105

packages/reactivity/__tests__/computed.spec.ts

@@ -1017,6 +1017,17 @@ describe('reactivity/computed', () => {
     expect(cValue.value).toBe(1)
   })
 
+  test('should not recompute if computed does not track reactive data', async () => {
+    const spy = vi.fn()
+    const c1 = computed(() => spy())
+
+    c1.value
+    ref(0).value++ // update globalVersion
+    c1.value
+
+    expect(spy).toBeCalledTimes(1)
+  })
+
   test('computed should remain live after losing all subscribers', () => {
     const state = reactive({ a: 1 })
     const p = computed(() => state.a + 1)

packages/reactivity/src/effect.ts

@@ -46,9 +46,14 @@ export enum EffectFlags {
   /**
    * ReactiveEffect only
    */
-  ALLOW_RECURSE = 1 << 7,
-  PAUSED = 1 << 8,
-  NOTIFIED = 1 << 9,
+  ACTIVE = 1 << 0,
+  RUNNING = 1 << 1,
+  TRACKING = 1 << 2,
+  NOTIFIED = 1 << 3,
+  DIRTY = 1 << 4,
+  ALLOW_RECURSE = 1 << 5,
+  PAUSED = 1 << 6,
+  EVALUATED = 1 << 7,
   STOP = 1 << 10,
 }
 
@@ -160,6 +165,11 @@ export class ReactiveEffect<T = any> implements ReactiveEffectOptions {
     ) {
       return true
     }
+    // @ts-expect-error only for backwards compatibility where libs manually set
+    // this flag - e.g. Pinia's testing module
+    if ((this as any)._dirty) {
+      return true
+    }
     return false
   }
 }
@@ -168,11 +178,6 @@ if (__DEV__) {
   setupOnTrigger(ReactiveEffect)
 }
 
-export interface ReactiveEffectRunner<T = any> {
-  (): T
-  effect: ReactiveEffect
-}
-
 export function effect<T = any>(
   fn: () => T,
   options?: ReactiveEffectOptions,