feat: add ZoomInfo Toolkit for CAMEL-AI framework #3389

haoye2 · 2025-11-06T12:22:34Z

Description

This pull request changed the branch; all subsequent commits will be made on this pull request.
This PR refactors the ZoomInfo toolkit by removing redundant fallback imports and cleaning up duplicate BaseToolkit dependencies. This is an improved version of the previous PR #3368, addressing the feedback and implementing a cleaner approach.

Note: I have created a new branch for this PR to ensure a clean history. All future commits and updates related to this refactoring will be made on this PR instead of the original PR #3368.

Changes Made

Remove redundant fallback imports from ZoomInfo toolkit
Clean up duplicate BaseToolkit imports to avoid circular dependencies
Simplify import structure for better maintainability
Ensure proper dependency management within the toolkit

Related Issues

Supersedes PR feat: add ZoomInfo Toolkit for CAMEL-AI framework #3368: This PR replaces the previous implementation with a cleaner approach
Branch Change: Moved to a new branch for better commit history management
Future Development: All related commits will continue on this PR

Testing

Verified that all imports work correctly
Tested ZoomInfo toolkit functionality
Ensured no circular dependencies exist
Confirmed that the toolkit initializes properly

Checklist

Code follows the project's style guidelines
Self-review of the code completed
Code is properly commented where necessary
Changes are tested and working as expected

Additional Context

This refactoring improves the overall code quality and removes unnecessary complexity from the ZoomInfo toolkit implementation. The changes are minimal but impactful for maintainability.

For reviewers: Please focus your review on this PR rather than PR #3368, as this contains the latest and cleanest implementation. The original PR can be closed once this one is approved.

coderabbitai · 2025-11-06T12:22:50Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

JINO-ROHIT

Thanks for the PR, i have added few comments, feel free to implement them if you think they make sense

JINO-ROHIT · 2025-11-06T12:54:00Z

camel/toolkits/zoominfo_toolkit.py

+    global _zoominfo_access_token, _zoominfo_token_expires_at
+
+    # Check if current token is still valid
+    if _zoominfo_access_token and time.time() < _zoominfo_token_expires_at:


is this necessary?

JINO-ROHIT · 2025-11-06T12:57:39Z

camel/toolkits/zoominfo_toolkit.py

+
+def _get_zoominfo_token() -> str:
+    r"""Get or refresh ZoomInfo JWT token."""
+    global _zoominfo_access_token, _zoominfo_token_expires_at


is there a reason to make this global? is there a more safer way to implement this? global vars have an issue with race conditions

JINO-ROHIT · 2025-11-06T12:59:16Z

also, it would be helpful to not reopen another PR, please update changes within the same PR

Wendong-Fan · 2025-11-06T13:02:53Z

thanks @haoye2 for the PR and @JINO-ROHIT for the review, awesome to see you back in the CAMEL community — warm welcome!

waleedalzarooni

Hey @haoye2,

Thanks for your work on the PR, looking forward to the final version!

waleedalzarooni · 2025-11-07T05:11:18Z

camel/toolkits/zoominfo_toolkit.py

+        response.raise_for_status()
+        return response.json()
+
+    except requests.exceptions.RequestException as e:


include some more info here for debugging
for example:

HTTP status code
Response body
Request endpoint
Original exception type

waleedalzarooni · 2025-11-07T05:16:04Z

camel/toolkits/zoominfo_toolkit.py

@@ -0,0 +1,312 @@
+# ========= Copyright 2023-2024 @ CAMEL-AI.org. All Rights Reserved. =========


could you ensure all necessary dependencies are added to pyproject.toml as per the guidelines in Contributing.MD (zi_api_auth_client, pyjwt, cryptography)

waleedalzarooni · 2025-11-07T05:23:38Z

camel/toolkits/__init__.py

    'NotionMCPToolkit',
    'VertexAIVeoToolkit',
    'MinimaxMCPToolkit',
+     "ZoomInfoToolkit",


Suggested change

"ZoomInfoToolkit",

"ZoomInfoToolkit",

spacing needs fixing

waleedalzarooni · 2025-11-07T05:25:35Z

camel/toolkits/zoominfo_toolkit.py

+
+import os
+import time
+import json


unused imports

import json from cryptography.hazmat.primitives import hashes from cryptography.hazmat.primitives.asymmetric import padding

waleedalzarooni · 2025-11-07T05:34:59Z

camel/toolkits/zoominfo_toolkit.py

+    json_data: Optional[Dict[str, Any]] = None,
+    params: Optional[Dict[str, Any]] = None,
+) -> Dict[str, Any]:
+    r"""Make a request to ZoomInfo API with proper error handling."""


docstring must match description conventions of other methods

waleedalzarooni · 2025-11-07T05:42:34Z

camel/toolkits/zoominfo_toolkit.py

+            headers=request_headers,
+            json=json_data,
+            params=params,
+            timeout=30,


should this use the configurable timeout parameter in __init__, if so possibly move the method inside the toolkit class

waleedalzarooni · 2025-11-07T05:46:24Z

camel/toolkits/zoominfo_toolkit.py

+        page: int = 1,
+        sort_by: Literal["name", "employeeCount", "revenue"] = "name",
+        sort_order: Literal["asc", "desc"] = "asc",
+        **kwargs


I think it would be best to remove the kwargs argument as it may confuse the agent and allow it to add incorrect params

waleedalzarooni · 2025-11-07T05:51:12Z

camel/toolkits/zoominfo_toolkit.py

+        (None, "ZOOMINFO_USERNAME"),
+        (None, "ZOOMINFO_PASSWORD"),
+    ])
+    # Search for companies by various criteria


remove all the comments above methods as descriptions within methods explain the purpose of functions anyways

waleedalzarooni · 2025-11-07T06:06:20Z

camel/toolkits/zoominfo_toolkit.py

+    def __init__(self, timeout: Optional[float] = None):
+        super().__init__(timeout=timeout)
+        # Validate credentials on initialization
+        _get_zoominfo_token()


remove _get_zoominfo_token() since it's already called in _make_info_request no need for redundant API call

waleedalzarooni · 2025-11-07T06:17:54Z

examples/toolkits/zoominfo_toolkit.py

@@ -0,0 +1,91 @@
+# ========= Copyright 2023-2024 @ CAMEL-AI.org. All Rights Reserved. =========


were you able to test this with the API since the free trial doesn't give you access to it

haoye2 added 3 commits November 4, 2025 15:02

feat: Add ZoomInfo toolkit for B2B data intelligence and contact search

412a592

Remove redundant fallback imports from zoominfo toolkit

3134f77

Remove fallback imports and clean up duplicate BaseToolkit import

07ddd37

haoye2 mentioned this pull request Nov 6, 2025

feat: add ZoomInfo Toolkit for CAMEL-AI framework #3368

Closed

6 tasks

waleedalzarooni requested review from JINO-ROHIT, Saedbhati, fengju0213 and waleedalzarooni November 6, 2025 12:38

JINO-ROHIT requested changes Nov 6, 2025

View reviewed changes

Merge branch 'master' into camel-zoominfo-fallback

50cbb47

JINO-ROHIT added the Waiting for Update PR has been reviewed, need to be updated based on review comment label Nov 6, 2025

Wendong-Fan assigned haoye2 Nov 6, 2025

waleedalzarooni reviewed Nov 7, 2025

View reviewed changes

		@@ -0,0 +1,312 @@
		# ========= Copyright 2023-2024 @ CAMEL-AI.org. All Rights Reserved. =========

		@@ -0,0 +1,91 @@
		# ========= Copyright 2023-2024 @ CAMEL-AI.org. All Rights Reserved. =========

feat: add ZoomInfo Toolkit for CAMEL-AI framework #3389

Are you sure you want to change the base?

feat: add ZoomInfo Toolkit for CAMEL-AI framework #3389

Uh oh!

Conversation

haoye2 commented Nov 6, 2025

Description

Changes Made

Related Issues

Testing

Checklist

Additional Context

Uh oh!

coderabbitai bot commented Nov 6, 2025

Review skipped

Uh oh!

JINO-ROHIT left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JINO-ROHIT commented Nov 6, 2025

Uh oh!

Wendong-Fan commented Nov 6, 2025

Uh oh!

waleedalzarooni left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants