Skip to content

Commit 85f5378

Browse files
google-labs-jules[bot]bosd
authored andcommitted
feat: Drop Python 3.8 support and add Python 3.13 tests
This commit drops support for Python 3.8, which was failing due to an issue with an older version of setuptools and the license field in pyproject.toml. The supported Python version range is now '>=3.9'. Additionally, this commit adds a test job for Python 3.13 to the CI workflow to ensure compatibility with the latest Python version. feat: Drop Python 3.8 support and add Python 3.13 tests This commit drops support for Python 3.8, which was failing due to an issue with an older version of setuptools in pyproject.toml. The supported Python version range is now '>=3.9'. Additionally, this commit adds a test job for Python 3.13 to the CI workflow to ensure compatibility with the latest Python version. fix: Update indices in noxfile.py This commit updates the indices in noxfile.py to point to the correct python versions after the list of supported versions was changed.
1 parent 572db02 commit 85f5378

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ jobs:
2525
- { python: "3.12", os: "ubuntu-latest", session: "tests" }
2626
- { python: "3.11", os: "ubuntu-latest", session: "tests" }
2727
- { python: "3.10", os: "ubuntu-latest", session: "tests" }
28-
- { python: "3.8", os: "ubuntu-latest", session: "tests" }
2928
- { python: "3.9", os: "ubuntu-latest", session: "tests" }
29+
- { python: "3.13", os: "ubuntu-latest", session: "tests" }
3030
- { python: "3.10", os: "windows-latest", session: "tests" }
3131
- { python: "3.10", os: "macos-latest", session: "tests" }
3232
- { python: "3.10", os: "ubuntu-latest", session: "typeguard" }

noxfile.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
package = "camelot"
1616

1717
# TODO: certain sessions are pinned to Python 3.10
18-
python_versions = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
18+
python_versions = ["3.9", "3.10", "3.11", "3.12", "3.13"]
1919
nox.needs_version = ">= 2021.6.6"
2020
nox.options.sessions = (
2121
"pre-commit",
@@ -106,7 +106,7 @@ def activate_virtualenv_in_precommit_hooks(session: Session) -> None:
106106
break
107107

108108

109-
@session(name="pre-commit", python=python_versions[2])
109+
@session(name="pre-commit", python=python_versions[1])
110110
def precommit(session: Session) -> None:
111111
"""Lint using pre-commit."""
112112
args = session.posargs or [
@@ -133,7 +133,7 @@ def precommit(session: Session) -> None:
133133
activate_virtualenv_in_precommit_hooks(session)
134134

135135

136-
@session(python=python_versions[2])
136+
@session(python=python_versions[1])
137137
def safety(session: Session) -> None:
138138
"""Scan dependencies for insecure packages."""
139139
requirements = session.run(
@@ -196,7 +196,7 @@ def tests(session: Session) -> None:
196196
session.notify("coverage", posargs=[])
197197

198198

199-
@session(python=python_versions[2])
199+
@session(python=python_versions[1])
200200
def coverage(session: Session) -> None:
201201
"""Produce the coverage report."""
202202
args = session.posargs or ["report", "-i"]
@@ -209,7 +209,7 @@ def coverage(session: Session) -> None:
209209
session.run("coverage", *args)
210210

211211

212-
@session(python=python_versions[2])
212+
@session(python=python_versions[1])
213213
def typeguard(session: Session) -> None:
214214
"""Runtime type checking using Typeguard."""
215215
session.install(".")
@@ -232,7 +232,7 @@ def xdoctest(session: Session) -> None:
232232
session.run("python", "-m", "xdoctest", *args)
233233

234234

235-
@session(name="docs-build", python=python_versions[5])
235+
@session(name="docs-build", python=python_versions[4])
236236
def docs_build(session: Session) -> None:
237237
"""Build the documentation."""
238238
args = session.posargs or ["docs", "docs/_build"]
@@ -258,7 +258,7 @@ def docs_build(session: Session) -> None:
258258
session.run("sphinx-build", *args)
259259

260260

261-
@session(python=python_versions[2])
261+
@session(python=python_versions[1])
262262
def docs(session: Session) -> None:
263263
"""Build and serve the documentation with live reloading on file changes."""
264264
args = session.posargs or ["--open-browser", "docs", "docs/_build"]

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ classifiers = [
1616
"Programming Language :: Python :: 3.12",
1717
"Programming Language :: Python :: 3.13",
1818
]
19-
requires-python = ">=3.8"
19+
requires-python = ">=3.9"
2020
dependencies = [
2121
"click>=8.0.1",
2222
"chardet>=5.1.0",

0 commit comments

Comments
 (0)