From f19362f9552efe7793245ccdb5d64752f8b02e5f Mon Sep 17 00:00:00 2001 From: James Crumpacker <48526250+DoomedJupiter@users.noreply.github.com> Date: Fri, 7 Nov 2025 10:31:34 -0600 Subject: [PATCH 1/5] Update test_cli.py added a test for when the version is not found --- tests/test_cli.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/test_cli.py b/tests/test_cli.py index a3801152..20f8f518 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -3,6 +3,8 @@ import warnings from unittest import mock +import importlib.metadata + import pytest from click.testing import CliRunner @@ -314,3 +316,10 @@ def test_import_error(): from camelot.cli import cli except ImportError: assert cli._HAS_MPL is False + + +def test_version_package_not_found(): + with mock.patch("importlib.metadata.version", side_effect=importlib.metadata.PackageNotFoundError): + from camelot.cli import get_version + assert get_version() is None + \ No newline at end of file From f90d6c952e569125fb27da43f0f9fed5ee8163ce Mon Sep 17 00:00:00 2001 From: James Crumpacker <48526250+DoomedJupiter@users.noreply.github.com> Date: Fri, 7 Nov 2025 10:40:26 -0600 Subject: [PATCH 2/5] Update test_cli.py minor formatting change to pass pre-commit CI tests --- tests/test_cli.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/test_cli.py b/tests/test_cli.py index 20f8f518..9c1f3136 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -1,10 +1,9 @@ +import importlib.metadata import os import sys import warnings from unittest import mock -import importlib.metadata - import pytest from click.testing import CliRunner @@ -319,7 +318,10 @@ def test_import_error(): def test_version_package_not_found(): - with mock.patch("importlib.metadata.version", side_effect=importlib.metadata.PackageNotFoundError): + with mock.patch( + "importlib.metadata.version", + side_effect=importlib.metadata.PackageNotFoundError + ): from camelot.cli import get_version - assert get_version() is None - \ No newline at end of file + + assert get_version() is None \ No newline at end of file From 58f1bac3e58df752b8dd8b408fbfd566874ffed1 Mon Sep 17 00:00:00 2001 From: James Crumpacker <48526250+DoomedJupiter@users.noreply.github.com> Date: Fri, 7 Nov 2025 10:45:41 -0600 Subject: [PATCH 3/5] Update test_cli.py added new line at end of file, to pass pre-commit CI tests --- tests/test_cli.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_cli.py b/tests/test_cli.py index 9c1f3136..a62ea180 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -324,4 +324,4 @@ def test_version_package_not_found(): ): from camelot.cli import get_version - assert get_version() is None \ No newline at end of file + assert get_version() is None From 85308a478c2ace347827a9aa0ce0544595c1c621 Mon Sep 17 00:00:00 2001 From: James Crumpacker <48526250+DoomedJupiter@users.noreply.github.com> Date: Fri, 7 Nov 2025 10:50:26 -0600 Subject: [PATCH 4/5] Update test_cli.py added a comma, to pass pre-commit CI tests, ...hopefully --- tests/test_cli.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_cli.py b/tests/test_cli.py index a62ea180..92f72e79 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -320,7 +320,7 @@ def test_import_error(): def test_version_package_not_found(): with mock.patch( "importlib.metadata.version", - side_effect=importlib.metadata.PackageNotFoundError + side_effect=importlib.metadata.PackageNotFoundError, ): from camelot.cli import get_version From 79c23b36e4e53da45486b9a18353ab49aabe8356 Mon Sep 17 00:00:00 2001 From: James Crumpacker <48526250+DoomedJupiter@users.noreply.github.com> Date: Fri, 7 Nov 2025 10:54:58 -0600 Subject: [PATCH 5/5] Update test_cli.py removed a space, to pass pre-commit CI tests, definitely this time --- tests/test_cli.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_cli.py b/tests/test_cli.py index 92f72e79..cb6bb683 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -319,7 +319,7 @@ def test_import_error(): def test_version_package_not_found(): with mock.patch( - "importlib.metadata.version", + "importlib.metadata.version", side_effect=importlib.metadata.PackageNotFoundError, ): from camelot.cli import get_version