fix: Ensure that formId and externalResource cannot be used together

related to camunda/camunda-modeler#5073

Author: yT0n1

packages/zeebe-element-templates-json-schema/src/defs/template.json

@@ -598,6 +598,70 @@
           }
         ]
       }
+    },
+    {
+      "if": {
+        "properties": {
+          "properties": {
+            "contains": {
+              "properties": {
+                "binding": {
+                  "properties": {
+                    "property": {
+                      "const": "formId"
+                    },
+                    "type": {
+                      "const": "zeebe:formDefinition"
+                    }
+                  },
+                  "required": [
+                    "property",
+                    "type"
+                  ]
+                }
+              },
+              "required": [
+                "binding"
+              ]
+            }
+          }
+        },
+        "required": [
+          "properties"
+        ]
+      },
+      "then": {
+        "properties": {
+          "properties": {
+            "not": {
+              "contains": {
+                "properties": {
+                  "binding": {
+                    "properties": {
+                      "type": {
+                        "const": "zeebe:formDefinition"
+                      },
+                      "property": {
+                        "const": "externalReference"
+                      }
+                    },
+                    "required": [
+                      "property",
+                      "type"
+                    ]
+                  }
+                },
+                "required": [
+                  "binding"
+                ]
+              }
+            }
+          }
+        },
+        "required": [
+          "properties"
+        ]
+      }
     }
   ]
 }

packages/zeebe-element-templates-json-schema/src/error-messages.json

@@ -315,5 +315,19 @@
       "then"
     ],
     "errorMessage": "Property \"resultVariable\" cannot be a Feel expression"
+  },
+  {
+    "path": [
+      "definitions",
+      "template",
+      "allOf",
+      1,
+      "allOf",
+      7,
+      "then",
+      "properties",
+      "properties"
+    ],
+    "errorMessage": "\"formId\" and \"externalReference\" cannot be used together"
   }
 ]

packages/zeebe-element-templates-json-schema/test/fixtures/form-definition-invalid-external-reference-and-formId.js

@@ -0,0 +1,83 @@
+export const template = {
+  '$schema': 'https://unpkg.com/@camunda/zeebe-element-templates-json-schema/resources/schema.json',
+  'name': 'Form Definition with external reference',
+  'id': 'formDefinitionWithExternalReference',
+  'appliesTo': [
+    'bpmn:Task'
+  ],
+  'elementType': {
+    'value': 'bpmn:UserTask'
+  },
+  'properties': [
+    {
+      'type': 'Hidden',
+      'binding': {
+        'type': 'zeebe:userTask',
+      }
+    },
+    {
+      'type': 'Hidden',
+      'value': 'aReference',
+      'binding': {
+        'type': 'zeebe:formDefinition',
+        'property': 'externalReference'
+      }
+    },
+    {
+      'type': 'Hidden',
+      'value': 'anId',
+      'binding': {
+        'type': 'zeebe:formDefinition',
+        'property': 'formId'
+      }
+    }
+  ]
+};
+
+export const errors = [
+  {
+    keyword: 'errorMessage',
+    dataPath: '/properties',
+    schemaPath: '#/allOf/1/allOf/7/then/properties/properties/errorMessage',
+    params: {
+      errors: [
+        {
+          keyword: 'not',
+          dataPath: '/properties',
+          schemaPath: '#/allOf/1/allOf/7/then/properties/properties/not',
+          params: {},
+          message: 'should NOT be valid',
+          emUsed: true
+        }
+      ]
+    },
+    message: '"formId" and "externalReference" cannot be used together'
+  },
+  {
+    keyword: 'if',
+    dataPath: '',
+    schemaPath: '#/allOf/1/allOf/7/if',
+    params: {
+      failingKeyword: 'then'
+    },
+    message: 'should match "then" schema'
+  },
+  {
+    keyword: 'type',
+    dataPath: '',
+    schemaPath: '#/oneOf/1/type',
+    params: {
+      type: 'array'
+    },
+    message: 'should be array'
+  },
+  {
+    keyword: 'oneOf',
+    dataPath: '',
+    schemaPath: '#/oneOf',
+    params: {
+      passingSchemas: null
+    },
+    message: 'should match exactly one schema in oneOf'
+  }
+];

packages/zeebe-element-templates-json-schema/test/spec/validationSpec.js

@@ -498,6 +498,8 @@ describe('validation', function() {
 
       it('form-definition-invalid-element-type');
 
+      it('form-definition-invalid-external-reference-and-formId');
+
       it('form-definition-invalid-formId-feel');
 
       it('form-definition-missing-zeebe-user-task');