fix: allow to use output* properties without task definition

Related to camunda/tmp-camunda-modeler-adhoc-subprocess#2

Author: barmac

packages/zeebe-element-templates-json-schema/CHANGELOG.md

@@ -6,6 +6,10 @@ All notable changes to [@camunda/zeebe-element-templates-json-schema](https://gi
 
 ___Note:__ Yet to be released changes appear here._
 
+## 0.31.1
+
+* `FIX`: allow to use `output*` properties without task definition in `bpmn:AdHocSubProcess`
+
 ## 0.31.0
 
 * `FEAT`: support `activeElementsCollection` property on `zeebe:adHoc` ([#198](https://github.com/camunda/element-templates-json-schema/pull/198))

packages/zeebe-element-templates-json-schema/src/defs/template/adHoc.json

@@ -62,7 +62,7 @@
       }
     },
     {
-      "$comment": "When zeebe:adHoc output properties are used, all three required bindings must be present together",
+      "$comment": "When zeebe:adHoc output properties are used, both required bindings must be present together",
       "if": {
         "properties": {
           "properties": {
@@ -145,29 +145,6 @@
                     "binding"
                   ]
                 }
-              },
-              {
-                "contains": {
-                  "properties": {
-                    "binding": {
-                      "properties": {
-                        "type": {
-                          "const": "zeebe:taskDefinition"
-                        },
-                        "property": {
-                          "const": "type"
-                        }
-                      },
-                      "required": [
-                        "type",
-                        "property"
-                      ]
-                    }
-                  },
-                  "required": [
-                    "binding"
-                  ]
-                }
               }
             ]
           }

packages/zeebe-element-templates-json-schema/src/error-messages.json

@@ -534,24 +534,6 @@
     ],
     "errorMessage": "When \"outputElement\" is defined for \"zeebe:adHoc\", \"outputCollection\" must be defined, too"
   },
-  {
-    "path": [
-      "definitions",
-      "template",
-      "allOf",
-      1,
-      "allOf",
-      9,
-      "allOf",
-      1,
-      "then",
-      "properties",
-      "properties",
-      "allOf",
-      2
-    ],
-    "errorMessage": "When using \"zeebe:adHoc\" with properties \"outputCollection\" and \"outputElement\", \"zeebe:taskDefinition\" with property=\"type\" must be set on the same element"
-  },
   {
     "path": [
       "definitions",

packages/zeebe-element-templates-json-schema/test/fixtures/ad-hoc/missing-task-definition-type-property.js

@@ -55,6 +55,48 @@ export const template = [
         'value': '=anActiveElementsCollection'
       }
     ]
+  },
+  {
+    '$schema': 'https://unpkg.com/@camunda/zeebe-element-templates-json-schema/resources/schema.json',
+    'name': 'AdHoc Template - BPMN implementation',
+    'id': 'io.camunda.examples.AdHoc.Valid.BPMN',
+    'description': 'activeElementsCollection, completionCondition, and cancelRemainingInstances',
+    'version': 2,
+    'appliesTo': [ 'bpmn:AdHocSubProcess' ],
+    'elementType': { 'value': 'bpmn:AdHocSubProcess' },
+    'properties': [
+      {
+        'type': 'Hidden',
+        'binding': {
+          'type': 'property',
+          'name': 'cancelRemainingInstances'
+        },
+        'value': 'false'
+      },
+      {
+        'type': 'String',
+        'feel': 'required',
+        'binding': {
+          'type': 'property',
+          'name': 'completionCondition'
+        }
+      },
+      {
+        'type': 'Hidden',
+        'binding': { 'type': 'zeebe:adHoc', 'property': 'activeElementsCollection' },
+        'value': '=anActiveElementsCollection'
+      },
+      {
+        'type': 'Hidden',
+        'binding': { 'type': 'zeebe:adHoc', 'property': 'outputCollection' },
+        'value': 'toolCallResults'
+      },
+      {
+        'type': 'Hidden',
+        'binding': { 'type': 'zeebe:adHoc', 'property': 'outputElement' },
+        'value': '={ id: toolCall._meta.id, name: toolCall._meta.name, content: toolCallResult }'
+      }
+    ]
   }
 ];
 

packages/zeebe-element-templates-json-schema/test/fixtures/ad-hoc/missing-task-definition.js

@@ -662,10 +662,6 @@ describe('validation', function() {
 
       it('ad-hoc/missing-output-element-feel');
 
-      it('ad-hoc/missing-task-definition');
-
-      it('ad-hoc/missing-task-definition-type-property');
-
       it('ad-hoc/valid');
 
     });