Skip to content

Commit 3644e09

Browse files
entangled90github-actions[bot]
authored andcommitted
fix: binary breaking change in ValList object
There's a breaking binary change that occurs in the monorepo when dmn version is compiled with a feel-engine version < 1.19.4. The error is the following: ```IncompatibleClassChange Class org.camunda.feel.syntaxtree.ValList$ does not implement the requested interface scala.Function1``` I think this was caused by the fact that now there are 2 apply methods. I'm not sure why Clirr didn't catch this error, maybe with MiMa it would been have caught (cherry picked from commit 9b2a2f1)
1 parent dbb331c commit 3644e09

File tree

1 file changed

+1
-1
lines changed
  • src/main/scala/org/camunda/feel/syntaxtree

1 file changed

+1
-1
lines changed

src/main/scala/org/camunda/feel/syntaxtree/Val.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ case class ValList(itemsAsSeq: Seq[Val]) extends Val {
323323
def copy(items: List[Val]): ValList = new ValList(items)
324324
}
325325

326-
object ValList {
326+
object ValList extends (List[Val] => ValList) {
327327
def apply(items: List[Val]): ValList = new ValList(items)
328328
def apply(items: Seq[Val]): ValList = new ValList(items)
329329
}

0 commit comments

Comments
 (0)