-
Notifications
You must be signed in to change notification settings - Fork 50
Description
Context
Currently, Charmed Kubeflow charms do not follow a common pattern in writing configuration files to the filesystem.
For instance, notebooks operator writes to /etc/config:
https://github.com/canonical/notebook-operators/blob/9e74713c6d9cd8d5189318784900934655cda49e/charms/jupyter-ui/src/charm.py#L75
Instead, admission webhook writes to /etc/webhook/certs: https://github.com/canonical/admission-webhook-operator/blob/a539fa48cc7146ce2e8c3ff79b7ea3fab4aa9e93/src/charm.py#L37
The same behaviour applies to other charms.
Proposal
Since rocks have the Pebble path /var/lib/pebble/default created with permissions 777, we could leverage this path to read/write configuration files whenever possible and configure the workload appropriately.
What needs to get done
- Define a common path pattern for workload configuration files
- Apply solution to
mainandtrackbranches of the charms - Update rocks to remove the useless permissions introduced by
install
Step (3) can be done in future, as it won't directly impact the charm.
Definition of Done
- Configuration file path pattern is defined
- Charms are updated
- Rocks are updated and integrated