Fix unit tests.

Author: Zvirovyi

tests/unit/test_charm.py

@@ -10,16 +10,21 @@
 
 from charm import CassandraCharm
 from core.state import PEER_RELATION
+from managers.config import ConfigManager
 
 BOOTSTRAP_RELATION = "bootstrap"
+PEER_SECRET = "cassandra-peers.cassandra.app"
+
+# TODO: add start change password unit test
 
 
 def test_start_leader():
     """Leader should render all required configs and start workload."""
     ctx = testing.Context(CassandraCharm)
     relation = testing.PeerRelation(id=1, endpoint=PEER_RELATION)
     bootstrap_relation = testing.PeerRelation(id=2, endpoint=BOOTSTRAP_RELATION)
-    state = testing.State(leader=True, relations={relation, bootstrap_relation})
+    secret = testing.Secret(label=PEER_SECRET, tracked_content={"cassandra-password": "ua"})
+    state = testing.State(leader=True, relations={relation, bootstrap_relation}, secrets={secret})
 
     with (
         patch("managers.config.ConfigManager.render_env") as render_env,
@@ -57,7 +62,8 @@ def test_start_subordinate_only_after_leader_active():
         relation = testing.PeerRelation(
             id=1, endpoint=PEER_RELATION, local_app_data={"cluster_state": "active"}
         )
-        state = testing.State(leader=False, relations={relation})
+        secret = testing.Secret(label=PEER_SECRET, tracked_content={"cassandra-password": "ua"})
+        state = testing.State(leader=False, relations={relation}, secrets={secret})
 
         state = ctx.run(ctx.on.start(), state)
         bootstrap.assert_called_once()
@@ -109,14 +115,16 @@ def test_config_changed():
     state = testing.State(leader=True, relations={relation, bootstrap_relation})
     with (
         patch("managers.config.ConfigManager.render_env") as render_env,
+        patch("managers.config.ConfigManager.render_cassandra_config") as render_cassandra_config,
         patch("charm.CassandraWorkload") as workload,
         patch(
             "managers.cluster.ClusterManager.is_healthy",
             new_callable=PropertyMock(return_value=True),
         ),
     ):
         state = ctx.run(ctx.on.config_changed(), state)
-        render_env.assert_called()
+        render_env.assert_not_called()
+        render_cassandra_config.assert_not_called()
         workload.return_value.restart.assert_not_called()
 
         relation = testing.PeerRelation(
@@ -127,4 +135,5 @@ def test_config_changed():
         render_env.reset_mock()
         state = ctx.run(ctx.on.config_changed(), state)
         render_env.assert_called()
+        render_cassandra_config.assert_called()
         workload.return_value.restart.assert_called_once()

tests/unit/test_config.py

@@ -12,7 +12,9 @@
 def test_render_env_preserves_existing_vars():
     """`render_env` should preserve existing environment variables."""
     workload = MagicMock(cassandra_paths=MagicMock(env=MagicMock()))
-    config_manager = ConfigManager(workload=workload, cluster_name="", listen_address="", seeds=[])
+    config_manager = ConfigManager(
+        workload=workload, cluster_name="", listen_address="", seeds=[], authentication=False
+    )
 
     workload.cassandra_paths.env.read_text.return_value = (
         "EXTRA_VAR=extra_value\nPATH=/custom/path\n"