Skip to content

Commit 9e6151a

Browse files
committed
ci: retain system packages for TICS workflow due to virtualenv version errors
Install system packages in TICS workflow until resolution is provided for inability to source virtualenv path during TICS analysis. Attempting to use tox virtualenv currently results in: Version string '<full_virtenv_python_path>:' too long for column 'VersionString.Name'
1 parent 306d66c commit 9e6151a

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

.github/workflows/weekly-tics.yml

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,23 @@ jobs:
2222

2323
- name: Dependencies
2424
run: |
25+
# TICS requires system packages insteed of virtualenvs to find
26+
# pytest. Otherwise we get annotations errors about inability to
27+
# find certain pylint dependencies.
28+
# Attempts to use tox virtual environments result in TICS analysis
29+
# failures: too long for column VersionString.Name.
2530
sudo DEBIAN_FRONTEND=noninteractive apt-get -qy update
2631
sudo DEBIAN_FRONTEND=noninteractive apt-get -qy install tox
32+
./tools/read-dependencies \
33+
--requirements-file requirements.txt \
34+
--requirements-file test-requirements.txt \
35+
--system-pkg-names --distro ubuntu 2> /dev/null \
36+
| xargs sudo DEBIAN_FRONTEND=noninteractive apt-get -qy install
37+
2738
- name: Generate coverage report and lint
2839
run: |
29-
tox -e py3 -- tests/unittests/ --cov-report=xml:.cover/coverage.xml --color=yes
30-
31-
# Export tox venv python so TICS uses pinned tox dependencies.
32-
tox -e pylint
33-
source .tox/pylint/bin/activate
34-
echo PATH=$PATH >> $GITHUB_ENV
40+
mkdir .cover
41+
pytest --cov=cloudinit --cov-report=xml:.cover/coverage.xml --color=yes
3542
3643
- name: Run TICS analysis with github-action
3744
uses: tiobe/tics-github-action@768de18bedf164ee461bc9ef5e2f2fa1a20b122a # v3.7

0 commit comments

Comments
 (0)