Add capi-auth-token file to control plane machines #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2024
bschimke95
approved these changes
Oct 10, 2024
bschimke95
left a comment
bschimke95
left a comment
There was a problem hiding this comment.
minor nits, looking good otherwise.
bschimke95
reviewed
Oct 11, 2024
bschimke95
left a comment
bschimke95
left a comment
There was a problem hiding this comment.
LGTM but need to wait for dependent PR before merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
/capi/etc/tokenfile with a random token to the control plane machines.PR series
dqlite-remove-endpointfeature branch to main:a. cluster-agent: Add Dqlite remove endpoint (KU-1719) microk8s-cluster-agent#57
b. control-plane provider: Call Dqlite remove endpoint for cleanup (KU-1719) cluster-api-control-plane-provider-microk8s#69