chore: rename cloud-runner-manager to vm-manager (#607)

* chore: rename cloud-runner-manager to vm-manager

* chore: rename cloud-runner-manager to vm-manager

Author: yanksyoon

github-runner-manager/src/github_runner_manager/manager/runner_manager.py

@@ -13,13 +13,13 @@
 
 from github_runner_manager import constants
 from github_runner_manager.errors import GithubMetricsError, RunnerError
-from github_runner_manager.manager.cloud_runner_manager import (
+from github_runner_manager.manager.models import InstanceID, RunnerIdentity, RunnerMetadata
+from github_runner_manager.manager.vm_manager import (
     CloudRunnerInstance,
     CloudRunnerManager,
     CloudRunnerState,
     HealthState,
 )
-from github_runner_manager.manager.models import InstanceID, RunnerIdentity, RunnerMetadata
 from github_runner_manager.metrics import events as metric_events
 from github_runner_manager.metrics import github as github_metrics
 from github_runner_manager.metrics import runner as runner_metrics

github-runner-manager/src/github_runner_manager/manager/runner_scaler.py

@@ -16,14 +16,14 @@
     MissingServerConfigError,
     ReconcileError,
 )
-from github_runner_manager.manager.cloud_runner_manager import HealthState
 from github_runner_manager.manager.runner_manager import (
     FlushMode,
     IssuedMetricEventsStats,
     RunnerInstance,
     RunnerManager,
     RunnerMetadata,
 )
+from github_runner_manager.manager.vm_manager import HealthState
 from github_runner_manager.metrics import events as metric_events
 from github_runner_manager.metrics.reconcile import (
     BUSY_RUNNERS_COUNT,

github-runner-manager/src/github_runner_manager/manager/cloud_runner_manager.py renamed to github-runner-manager/src/github_runner_manager/manager/vm_manager.py

@@ -94,33 +94,6 @@ def from_openstack_server_status(  # pragma: no cover
         return state
 
 
-class CloudInitStatus(str, Enum):
-    """Represents the state of cloud-init script.
-
-    The cloud init script is used to launch ephemeral GitHub runners. If the script is being
-    initialized, GitHub runner is listening for jobs or GitHub runner is running the job, the
-    cloud-init script should report "running" status.
-
-    Refer to the official documentation on cloud-init status:
-    https://cloudinit.readthedocs.io/en/latest/howto/status.html.
-
-    Attributes:
-        NOT_STARTED: The cloud-init script has not yet been started.
-        RUNNING: The cloud-init script is running.
-        DONE: The cloud-init script has completed successfully.
-        ERROR: There was an error while running the cloud-init script.
-        DEGRADED: There was a non-critical issue while running the cloud-inits script.
-        DISABLED: Cloud init was disabled by other system configurations.
-    """
-
-    NOT_STARTED = "not started"
-    RUNNING = "running"
-    DONE = "done"
-    ERROR = "error"
-    DEGRADED = "degraded"
-    DISABLED = "disabled"
-
-
 @dataclass
 class CloudRunnerInstance:
     """Information on the runner on the cloud.
@@ -261,6 +234,7 @@ def get_runners(self) -> Sequence[CloudRunnerInstance]:
         """Get cloud self-hosted runners."""
 
     @abc.abstractmethod
+    # Abstract methods do not have a return value, ignore the docstring error DCO031
     def delete_vms(self, instance_ids: Sequence[InstanceID]) -> list[InstanceID]:
         """Delete cloud VM instances.
 
@@ -269,9 +243,10 @@ def delete_vms(self, instance_ids: Sequence[InstanceID]) -> list[InstanceID]:
 
         Returns:
             The deleted instance IDs.
-        """
+        """  # noqa: DCO031
 
     @abc.abstractmethod
+    # Abstract methods do not have a return value, ignore the docstring error DCO031
     def extract_metrics(self, instance_ids: Sequence[InstanceID]) -> list[RunnerMetrics]:
         """Extract metrics from cloud VMs.
 
@@ -280,7 +255,7 @@ def extract_metrics(self, instance_ids: Sequence[InstanceID]) -> list[RunnerMetr
 
         Returns:
             The fetched runner metrics.
-        """
+        """  # noqa: DCO031
 
     @abc.abstractmethod
     def cleanup(self) -> None:

github-runner-manager/src/github_runner_manager/metrics/events.py

@@ -9,7 +9,7 @@
 from pydantic import BaseModel, NonNegativeFloat
 
 from github_runner_manager.errors import IssueMetricEventError
-from github_runner_manager.manager.cloud_runner_manager import CodeInformation
+from github_runner_manager.manager.vm_manager import CodeInformation
 
 METRICS_LOG_PATH = Path("/var/log/github-runner-metrics.log")
 

github-runner-manager/src/github_runner_manager/metrics/runner.py

@@ -17,12 +17,8 @@
 from pydantic import ValidationError
 
 from github_runner_manager.errors import IssueMetricEventError, RunnerMetricsError, SSHError
-from github_runner_manager.manager.cloud_runner_manager import (
-    PostJobMetrics,
-    PreJobMetrics,
-    RunnerMetrics,
-)
 from github_runner_manager.manager.models import InstanceID
+from github_runner_manager.manager.vm_manager import PostJobMetrics, PreJobMetrics, RunnerMetrics
 from github_runner_manager.metrics import events as metric_events
 from github_runner_manager.metrics.type import GithubJobMetrics
 from github_runner_manager.openstack_cloud.constants import (

github-runner-manager/src/github_runner_manager/openstack_cloud/openstack_runner_manager.py

@@ -16,14 +16,14 @@
     OpenStackError,
     RunnerCreateError,
 )
-from github_runner_manager.manager.cloud_runner_manager import (
+from github_runner_manager.manager.models import InstanceID, RunnerContext, RunnerIdentity
+from github_runner_manager.manager.runner_manager import HealthState
+from github_runner_manager.manager.vm_manager import (
     CloudRunnerInstance,
     CloudRunnerManager,
     CloudRunnerState,
     RunnerMetrics,
 )
-from github_runner_manager.manager.models import InstanceID, RunnerContext, RunnerIdentity
-from github_runner_manager.manager.runner_manager import HealthState
 from github_runner_manager.metrics import runner as runner_metrics
 from github_runner_manager.openstack_cloud.constants import (
     CREATE_SERVER_TIMEOUT,

github-runner-manager/tests/unit/factories/metrics_factory.py

@@ -5,7 +5,7 @@
 
 import factory
 
-from github_runner_manager.manager.cloud_runner_manager import CodeInformation
+from github_runner_manager.manager.vm_manager import CodeInformation
 from github_runner_manager.metrics.events import Event, RunnerInstalled, RunnerStop
 
 

github-runner-manager/tests/unit/factories/runner_instance_factory.py

@@ -8,13 +8,10 @@
 
 import factory
 
-from github_runner_manager.manager.cloud_runner_manager import (
-    CloudRunnerInstance,
-    CloudRunnerState,
-)
-from github_runner_manager.manager.cloud_runner_manager import HealthState as CloudHelathState
 from github_runner_manager.manager.models import InstanceID, RunnerIdentity, RunnerMetadata
 from github_runner_manager.manager.runner_manager import RunnerInstance
+from github_runner_manager.manager.vm_manager import CloudRunnerInstance, CloudRunnerState
+from github_runner_manager.manager.vm_manager import HealthState as CloudHelathState
 from github_runner_manager.platform.platform_provider import (
     PlatformRunnerHealth,
     PlatformRunnerState,

github-runner-manager/tests/unit/fake_runner_managers.py

@@ -6,16 +6,13 @@
 
 from pydantic import HttpUrl
 
-from github_runner_manager.manager.cloud_runner_manager import (
-    CloudRunnerInstance,
-    CloudRunnerManager,
-)
 from github_runner_manager.manager.models import (
     InstanceID,
     RunnerContext,
     RunnerIdentity,
     RunnerMetadata,
 )
+from github_runner_manager.manager.vm_manager import CloudRunnerInstance, CloudRunnerManager
 from github_runner_manager.metrics.runner import RunnerMetrics
 from github_runner_manager.openstack_cloud.openstack_cloud import _MAX_NOVA_COMPUTE_API_VERSION
 from github_runner_manager.platform.platform_provider import (

github-runner-manager/tests/unit/manager/test_runner_manager.py

@@ -7,12 +7,9 @@
 
 import pytest
 
-from github_runner_manager.manager.cloud_runner_manager import (
-    CloudRunnerInstance,
-    CloudRunnerManager,
-)
 from github_runner_manager.manager.models import RunnerMetadata
 from github_runner_manager.manager.runner_manager import FlushMode, RunnerInstance, RunnerManager
+from github_runner_manager.manager.vm_manager import CloudRunnerInstance, CloudRunnerManager
 from github_runner_manager.platform.platform_provider import PlatformProvider
 from github_runner_manager.types_.github import SelfHostedRunner
 from tests.unit.factories.runner_instance_factory import (