Skip to content

Commit d70f16e

Browse files
cbartzerinecon
andauthored
docs: enable vale style checks (#571)
* update docs according to vale style check warnings * update docs according to vale style check warnings * enable vale-style-check * Apply suggestions from code review Co-authored-by: Erin Conley <[email protected]> --------- Co-authored-by: Erin Conley <[email protected]>
1 parent a212247 commit d70f16e

File tree

12 files changed

+41
-14
lines changed

12 files changed

+41
-14
lines changed

.github/workflows/test.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ jobs:
1010
with:
1111
self-hosted-runner: true
1212
self-hosted-runner-label: edge
13+
vale-style-check: true

docs/changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
# Changelog
22

3+
This changelog documents user-relevant changes to the GitHub runner charm.
4+
5+
36
### 2025-06-17
47

58
- Fix bug where SSH connection error always appears in the logs.
69

10+
711
### 2025-06-16
812

913
- Revert copytruncate logrotate method for reactive processes, as copytruncate keeps log files on disks and does not remove them, and each process is writing to a new file leading to a huge and increasing amount

docs/how-to/openstack-runner.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ The first cloud in the `clouds.yaml` is used by the charm.
2929

3030
Here is a sample of the `clouds.yaml`:
3131

32-
```yaml
32+
```
3333
clouds:
3434
cloud:
3535
auth:

docs/index.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ For the github-runner-operator charm, this includes:
88
* Configurable resource limits.
99
* Ability to redeploy without losing any data (no need to back up).
1010
* Supported observability through the `cos-agent` integration.
11-
* Scheduled dependences upgrades to mitigate security risks. Furthermore, the landscape-client charm can be deployed with this charm to ensure other dependencies are kept up to date.
11+
* Scheduled dependences upgrades to mitigate security risks. Furthermore, the Landscape Client charm can be deployed with this charm to ensure other dependencies are kept up to date.
1212

1313
Operating a self-hosted runner comes with [certain security concerns according to GitHub](https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners#self-hosted-runner-security).
1414
Just like GitHub's runners, the self-hosted runners managed by the charm are isolated in a single-use virtual machine.
@@ -24,7 +24,10 @@ The charm enforces a set of GitHub repository settings as best practice. This is
2424
| [Overview](https://charmhub.io/github-runner)</br> Overview of the charm </br> | [How-to guides](https://charmhub.io/github-runner/docs/how-to-openstack-runner) </br> Step-by-step guides covering key operations and common tasks |
2525
| [Reference](https://charmhub.io/github-runner/docs/reference-actions) </br> Technical information - specifications, APIs, architecture | [Explanation](https://charmhub.io/github-runner/docs/explanation-charm-architecture) </br> Concepts - discussion and clarification of key topics |
2626

27+
<!-- vale Canonical.004-Canonical-product-names = NO -->
2728
If you want to use ephemeral LXD virtual machines spawned by charm, you can refer to the section [Track local-lxd](https://charmhub.io/github-runner/docs/local-lxd).
29+
<!-- vale Canonical.004-Canonical-product-names = YES -->
30+
2831

2932
## Contributing to this documentation
3033

@@ -44,7 +47,7 @@ The GitHub runner charm is a member of the Ubuntu family. It's an open-source pr
4447
Thinking about using the GitHub runner charm for your next project? [Get in touch](https://matrix.to/#/#charmhub-charmdev:ubuntu.com)!
4548

4649
# Contents
47-
50+
<!-- vale Canonical.004-Canonical-product-names = NO -->
4851
1. [How to](how-to)
4952
1. [Change repository or organization](how-to/change-path.md)
5053
1. [Change GitHub personal access token](how-to/change-token.md)
@@ -95,4 +98,5 @@ Thinking about using the GitHub runner charm for your next project? [Get in touc
9598
1. [Explanation](local-lxd/explanation)
9699
1. [ARM64](local-lxd/explanation/arm64.md)
97100
1. [Charm architecture](local-lxd/explanation/charm-architecture.md)
98-
1. [SSH Debug](local-lxd/explanation/ssh-debug.md)
101+
1. [SSH Debug](local-lxd/explanation/ssh-debug.md)
102+
<!-- vale Canonical.004-Canonical-product-names = YES -->

docs/local-lxd/explanation/arm64.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# ARM64
22

3-
### Nested virtualiztion support
3+
4+
For ARM64, the charm needs to be deployed on a bare metal instance. This is due to the fact that the
45

56
GitHub runner uses [LXD](https://github.com/canonical/lxd) to create a virtual machine to run the
67
GitHub runner's binary. Some versions of the ARM64 architecture do not support nested
@@ -22,4 +23,6 @@ to be further developed.
2223
- Kernel (KVM): upstream not yet ready
2324
- Userspace programs (e.g. qemu): unsupported.
2425

25-
Therefore, it is currently necessary that the charm is deployed on a bare metal instance.
26+
Therefore, it is currently necessary that the charm is deployed on a bare metal instance.
27+
For instance, you can use any of the [ARM64 metal instances](https://aws.amazon.com/ec2/instance-types/) to provide Juju
28+
with ARM64 bare metal instances. Some of the examples include: a1.metal, m7g.metal.

docs/local-lxd/explanation/charm-architecture.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,13 @@ The software installed in the image includes:
4141
- `yq`
4242

4343
The configurations applied in the image include:
44-
44+
<!-- vale Canonical.005-Industry-product-names = NO -->
4545
- Creating a group named `microk8s`.
4646
- Adding the `ubuntu` user to the `microk8s` group. Note that the `microk8s` package is not installed in the image; this preconfigures the group for users who install the package.
4747
- Adding the `ubuntu` user to the `docker` group.
4848
- Adding iptables rules to accept traffic for the DOCKER-USER chain. This resolves a networking conflict with LXD.
49+
<!-- vale Canonical.005-Industry-product-names = YES -->
50+
4951

5052
## Network configuration
5153

docs/local-lxd/reference/arm64.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

docs/local-lxd/reference/integrations.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Integrations
22

3+
This is a list of relations supported by the GitHub Runner charm.
4+
35
## debug-ssh
46

57
_Interface_: debug-ssh

docs/local-lxd/reference/token-scopes.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Token scopes
22

3+
In order to use the GitHub runner charm, a personal access token with the necessary permissions
4+
is required.
5+
36
## Fine grained access token scopes
47

58
**Note**: In addition to having a token with the necessary permissions, the user who owns the
@@ -34,6 +37,9 @@ repository runner.
3437

3538
## Personal access token scopes
3639

40+
Depending on whether the charm is used for GitHub organizations or repositories, the following scopes
41+
should be selected when creating a personal access token.
42+
3743
### Organizational Runners
3844

3945
To use this charm for GitHub organizations, the following scopes should be selected:

docs/local-lxd/tutorial/quick-start.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Deploy the GitHub runner charm for the first time
22

3+
This tutorial shows you how to deploy the GitHub runner charm for the first time using Juju on a local LXD controller.
4+
The charm will deploy a self-hosted runner that can be used to run GitHub Actions jobs.
5+
36
## What you'll do
47

58
- Set up a GitHub repository
@@ -80,7 +83,7 @@ Replacing the `<TOKEN>` with the personal access token, and `<OWNER/REPO>` the G
8083

8184
The `--constraints` option for the `juju deploy` sets the resource requirements for the Juju machine hosting the charm application. This is used to accommodate different sizes of self-hosted runners. For details, refer to [Managing resource usage](https://charmhub.io/github-runner/docs/managing-resource-usage).
8285

83-
The `--storage` option mounts a juju storage to be used as the disk for LXD instances hosting the self-hosted runners. Refer [How to configure runner storage](https://charmhub.io/github-runner/docs/configure-runner-storage) for more information.
86+
The `--storage` option mounts a Juju storage to be used as the disk for LXD instances hosting the self-hosted runners. Refer [How to configure runner storage](https://charmhub.io/github-runner/docs/configure-runner-storage) for more information.
8487

8588
The charm performs various installation and configuration on startup. The charm might upgrade the kernel of the Juju machine and reboot the Juju machine. During reboot, the Juju machine will go into the `down` state; this is a part of the normal reboot process and the Juju machine should be restarted after a while.
8689

0 commit comments

Comments
 (0)