rename update_termination_grace_period + close all k8s clients

Author: MiaAltieri

src/charm.py

@@ -714,13 +714,14 @@ def _on_webhook_mutator_pebble_ready(self, event) -> None:
         generate_mutating_webhook(
             client, self.unit, self.model.name, cert, self.mutator_service_name
         )
+        client.close()
 
         # We must ensure that juju does not overwrite our termination period, so we should update
         # it as needed. However, updating the termination period can result in an onslaught of
         # events, including the upgrade event. To prevent this from messing with upgrades do not
         # update the termination period when an upgrade is occurring.
         if self.get_current_termination_period() != ONE_YEAR and not self.upgrade_in_progress:
-            self.update_termination_grace_period(ONE_YEAR)
+            self.update_termination_grace_period_to_one_year()
 
     def _configure_layers(self, container: Container) -> None:
         """Configure the layers of the container."""
@@ -988,6 +989,7 @@ def get_current_termination_period(self) -> int:
         """Returns the current termination period for the stateful set of this juju application."""
         client = Client()
         statefulset = client.get(StatefulSet, name=self.app.name, namespace=self.model.name)
+        client.close()
         return statefulset.spec.template.spec.terminationGracePeriodSeconds
 
     def get_termination_period_for_pod(self) -> int:
@@ -996,9 +998,10 @@ def get_termination_period_for_pod(self) -> int:
         client = Client()
         pod = client.get(Pod, name=pod_name, namespace=self.model.name)
         termination_grace_period = pod.spec.terminationGracePeriodSeconds
+        client.close()
         return termination_grace_period
 
-    def update_termination_grace_period(self, seconds: int) -> None:
+    def update_termination_grace_period_to_one_year(self) -> None:
         """Patch the termination grace period for the stateful set of this juju application."""
         client = Client()
         patch_data = {
@@ -1018,6 +1021,7 @@ def update_termination_grace_period(self, seconds: int) -> None:
         )
         # Works because we're leader.
         self.needs_new_termination_period = False
+        client.close()
 
     def __handle_partition_on_stop(self) -> None:
         """Raise partition to prevent other units from restarting if an upgrade is in progress.
@@ -1187,7 +1191,7 @@ def _handle_termination(self):
             return
         try:
             if self.get_current_termination_period() != ONE_YEAR and not self.upgrade_in_progress:
-                self.update_termination_grace_period(ONE_YEAR)
+                self.update_termination_grace_period_to_one_year()
         except ApiError:
             logger.info("Failed to update termination period.")
             return