You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+14-37Lines changed: 14 additions & 37 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -5,44 +5,18 @@
5
5
This documents explains the processes and practices recommended for contributing enhancements to
6
6
this operator.
7
7
8
-
- Generally, before developing enhancements to this charm, you should consider [opening an issue
9
-
](https://github.com/canonical/mongodb-k8s-operator/issues) explaining your use case.
10
-
- If you would like to chat with us about your use-cases or proposed implementation, you can reach
11
-
us at [Canonical Mattermost public channel](https://chat.charmhub.io/charmhub/channels/charm-dev)
12
-
or [Discourse](https://discourse.charmhub.io/).
13
-
- Familiarising yourself with the [Charmed Operator Framework](https://juju.is/docs/sdk) library
14
-
will help you a lot when working on new features or bug fixes.
15
-
- All enhancements require review before being merged. Code review typically examines
8
+
**Note:** The charm's python business logic is written in a shared library that can be found [here](https://github.com/canonical/mongo-single-kernel-library). This is where python contributions should be made.
9
+
10
+
- Generally, before developing enhancements to this charm, you should consider opening an issue [on Single Kernel repository](https://github.com/canonical/mongo-single-kernel-library/issues) explaining your use case.
11
+
- If you would like to chat with us about your use-cases or proposed implementation, you can reach us on our [Matrix channel](https://matrix.to/#/#charmhub-data-platform:ubuntu.com) or in [Discourse](https://discourse.charmhub.io/).
12
+
- Familiarising yourself with the [Charmed Operator Framework](https://juju.is/docs/sdk) library will help you a lot when working on new features or bug fixes.
13
+
- All enhancements require review before being merged. Additionally, new code must pass the tests. Code review typically examines
16
14
- code quality
17
15
- test coverage
18
-
- user experience for Juju administrators this charm.
19
-
- Please help us out in ensuring easy to review branches by rebasing your pull request branch onto
20
-
the `main` branch. This also avoids merge commits and creates a linear Git commit history.
- user experience for Juju administrators of this charm.
17
+
- Please help us out in ensuring easy to review branches by rebasing your pull request branch onto the `main` branch. This also avoids merge commits and creates a linear Git commit history.
18
+
- Once the code has been merged on the [repository](https://github.com/canonical/mongo-single-kernel-library/) of the Mongo Single Kernel lib, wait for a new version of the [python package](https://pypi.org/project/mongo-charms-single-kernel/) to be published, and create a PR on this repository that bumps the version of the package, and on the 3 other repositories ([MongoDB VM](https://github.com/canonical/mongodb-operator), [Mongos VM](https://github.com/canonical/mongos-operator) and [Mongos k8s](https://github.com/canonical/mongos-k8s-operator)).
19
+
- If you added some new interfaces, please don't forget to add them here.
46
20
47
21
### Testing
48
22
@@ -51,6 +25,7 @@ tox run -e fmt # update your code according to linting rules
51
25
tox run -e lint # code style
52
26
tox run -e unit # unit tests
53
27
tox run -e integration # integration tests
28
+
tox run -e integration -- 'tests/integration/test_charm.py' --group='1'# charm integration tests
0 commit comments