Raise error when role name > 32 chars

Author: sinclert-canonical

docs/reference/software-testing.md

@@ -41,13 +41,13 @@ juju run mysql-test-app/leader get-inserted-data
 # Start "continuous write" test:
 juju run mysql-test-app/leader start-continuous-writes
 export password=$(juju run mysql-k8s/leader get-password username=root | yq '.. | select(. | has("password")).password')
-watch -n1 -x juju ssh --container mysql mysql-k8s/leader "mysql -h 127.0.0.1 -uroot -p${password} -e \"select count(*) from continuous_writes_database.data\""
+watch -n1 -x juju ssh --container mysql mysql-k8s/leader "mysql -h 127.0.0.1 -uroot -p${password} -e \"select count(*) from continuous_writes.data\""
 
 # Watch the counter is growing!
 ```
 Expected results:
 
-* mysql-test-app continuously inserts records in database `continuous_writes_database` table `data`.
+* mysql-test-app continuously inserts records in database `continuous_writes` table `data`.
 * the counters (amount of records in table) are growing on all cluster members
 
 Hints:

lib/charms/mysql/v0/mysql.py

@@ -1510,12 +1510,9 @@ def create_database(self, database: str) -> None:
         """Create an application database."""
         role_name = f"charmed_dba_{database}"
 
-        if len(database) >= ROLE_MAX_LENGTH:
-            logger.error(f"Failed to create application database {database}")
-            raise MySQLCreateApplicationDatabaseError("Name longer than 32 characters")
         if len(role_name) >= ROLE_MAX_LENGTH:
-            logger.warning(f"Pruning application database role name {role_name}")
-            role_name = role_name[:ROLE_MAX_LENGTH]
+            logger.error(f"Failed to create application database {database}")
+            raise MySQLCreateApplicationDatabaseError("Role name longer than 32 characters")
 
         create_database_commands = (
             "shell.connect_to_primary()",

tests/integration/high_availability/high_availability_helpers.py

@@ -32,7 +32,7 @@
 )
 
 # Copied these values from high_availability.application_charm.src.charm
-DATABASE_NAME = "continuous_writes_database"
+DATABASE_NAME = "continuous_writes"
 TABLE_NAME = "data"
 
 CLUSTER_NAME = "test_cluster"

tests/integration/relations/test_mysql_root.py

@@ -29,7 +29,7 @@ async def test_build_and_deploy(ops_test: OpsTest, charm):
     config = {
         "profile": "testing",
         "mysql-root-interface-user": "test-user",
-        "mysql-root-interface-database": "continuous_writes_database",
+        "mysql-root-interface-database": "continuous_writes",
     }
     resources = {
         "mysql-image": DB_METADATA["resources"]["mysql-image"]["upstream-source"],