[DPE-3881] Use ruff as a linter and formatter (#489)

* Use ruff as a linter and formatter

* Comment all ignore rules

* Bump mysql and tls libs libpatch

Author: shayancanonical

lib/charms/mysql/v0/async_replication.py

@@ -54,7 +54,7 @@
 # The unique Charmhub library identifier, never change it
 LIBID = "4de21f1a022c4e2c87ac8e672ec16f6a"
 LIBAPI = 0
-LIBPATCH = 5
+LIBPATCH = 6
 
 RELATION_OFFER = "replication-offer"
 RELATION_CONSUMER = "replication"
@@ -778,9 +778,10 @@ def _on_consumer_changed(self, event):  # noqa: C901
                 logger.debug("Recreating cluster prior to sync credentials")
                 self._charm.create_cluster()
                 # (re)set flags
-                self._charm.app_peer_data.update(
-                    {"removed-from-cluster-set": "", "rejoin-secondaries": "true"}
-                )
+                self._charm.app_peer_data.update({
+                    "removed-from-cluster-set": "",
+                    "rejoin-secondaries": "true",
+                })
                 event.defer()
                 return
             if not self._charm.cluster_fully_initialized:

lib/charms/mysql/v0/backups.py

@@ -99,7 +99,7 @@ def is_unit_blocked(self) -> bool:
 
 # Increment this PATCH version before using `charmcraft publish-lib` or reset
 # to 0 if you are raising the major API version
-LIBPATCH = 10
+LIBPATCH = 11
 
 
 if typing.TYPE_CHECKING:
@@ -314,11 +314,9 @@ def _on_create_backup(self, event: ActionEvent) -> None:
             return
 
         logger.info(f"Backup succeeded: with backup-id {datetime_backup_requested}")
-        event.set_results(
-            {
-                "backup-id": datetime_backup_requested,
-            }
-        )
+        event.set_results({
+            "backup-id": datetime_backup_requested,
+        })
         self.charm._on_update_status(None)
 
     def _can_unit_perform_backup(self) -> Tuple[bool, Optional[str]]:
@@ -538,11 +536,9 @@ def _on_restore(self, event: ActionEvent) -> None:
             return
 
         logger.info("Restore succeeded")
-        event.set_results(
-            {
-                "completed": "ok",
-            }
-        )
+        event.set_results({
+            "completed": "ok",
+        })
         # update status as soon as possible
         self.charm._on_update_status(None)
 

lib/charms/mysql/v0/mysql.py

@@ -128,7 +128,7 @@ def wait_until_mysql_connection(self) -> None:
 # Increment this major API version when introducing breaking changes
 LIBAPI = 0
 
-LIBPATCH = 64
+LIBPATCH = 65
 
 UNIT_TEARDOWN_LOCKNAME = "unit-teardown"
 UNIT_ADD_LOCKNAME = "unit-add"
@@ -421,9 +421,7 @@ def __init__(self, *args):
         super().__init__(*args)
 
         # disable support
-        disable_file = Path(
-            f"{os.environ.get('CHARM_DIR')}/disable"
-        )  # pyright: ignore [reportArgumentType]
+        disable_file = Path(f"{os.environ.get('CHARM_DIR')}/disable")  # pyright: ignore [reportArgumentType]
         if disable_file.exists():
             logger.warning(
                 f"\n\tDisable file `{disable_file.resolve()}` found, the charm will skip all events."
@@ -539,19 +537,15 @@ def _get_cluster_status(self, event: ActionEvent) -> None:
             status = self._mysql.get_cluster_status()
 
         if status:
-            event.set_results(
-                {
-                    "success": True,
-                    "status": status,
-                }
-            )
+            event.set_results({
+                "success": True,
+                "status": status,
+            })
         else:
-            event.set_results(
-                {
-                    "success": False,
-                    "message": "Failed to read cluster status.  See logs for more information.",
-                }
-            )
+            event.set_results({
+                "success": False,
+                "message": "Failed to read cluster status.  See logs for more information.",
+            })
 
     def _recreate_cluster(self, event: ActionEvent) -> None:
         """Action used to recreate the cluster, for special cases."""
@@ -564,9 +558,9 @@ def _recreate_cluster(self, event: ActionEvent) -> None:
             del self.app_peer_data["removed-from-cluster-set"]
 
         # reset cluster-set-name to config or previous value
-        hash = self.generate_random_hash()
+        random_hash = self.generate_random_hash()
         self.app_peer_data["cluster-set-domain-name"] = self.model.config.get(
-            "cluster-set-name", f"cluster-set-{hash}"
+            "cluster-set-name", f"cluster-set-{random_hash}"
         )
 
         logger.info("Recreating cluster")
@@ -1226,12 +1220,10 @@ def configure_instance(self, create_cluster_admin: bool = True) -> None:
         }
 
         if create_cluster_admin:
-            options.update(
-                {
-                    "clusterAdmin": self.cluster_admin_user,
-                    "clusterAdminPassword": self.cluster_admin_password,
-                }
-            )
+            options.update({
+                "clusterAdmin": self.cluster_admin_user,
+                "clusterAdminPassword": self.cluster_admin_password,
+            })
 
         configure_instance_command = (
             f"dba.configure_instance('{self.server_config_user}:{self.server_config_password}@{self.instance_address}', {json.dumps(options)})",
@@ -1805,15 +1797,15 @@ def execute_remove_instance(
         reraise=True,
         wait=wait_random(min=4, max=30),
     )
-    def remove_instance(self, unit_label: str, lock_instance: Optional[str] = None) -> None:
+    def remove_instance(self, unit_label: str, lock_instance: Optional[str] = None) -> None:  # noqa: C901
         """Remove instance from the cluster.
 
         This method is called from each unit being torn down, thus we must obtain
         locks on the cluster primary. There is a retry mechanism for any issues
         obtaining the lock, removing instances/dissolving the cluster, or releasing
         the lock.
         """
-        remaining_cluster_member_addresses = list()
+        remaining_cluster_member_addresses = []
         skip_release_lock = False
         try:
             # Get the cluster primary's address to direct lock acquisition request to.
@@ -2818,9 +2810,9 @@ def flush_mysql_logs(self, logs_type: Union[MySQLTextLogs, list[MySQLTextLogs]])
         ]
 
         if isinstance(logs_type, list):
-            flush_logs_commands.extend(
-                [f"session.run_sql('FLUSH {log.value}')" for log in logs_type]
-            )
+            flush_logs_commands.extend([
+                f"session.run_sql('FLUSH {log.value}')" for log in logs_type
+            ])
         else:
             flush_logs_commands.append(f'session.run_sql("FLUSH {logs_type.value}")')  # type: ignore
 

lib/charms/mysql/v0/s3_helpers.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 """S3 helper functions for the MySQL charms."""
+
 import base64
 import logging
 import tempfile
@@ -31,7 +32,7 @@
 
 # Increment this PATCH version before using `charmcraft publish-lib` or reset
 # to 0 if you are raising the major API version
-LIBPATCH = 8
+LIBPATCH = 9
 
 # botocore/urllib3 clutter the logs when on debug
 logging.getLogger("botocore").setLevel(logging.WARNING)

lib/charms/mysql/v0/tls.py

@@ -19,7 +19,6 @@
 
 """
 
-
 import base64
 import logging
 import re
@@ -52,7 +51,7 @@
 
 LIBID = "eb73947deedd4380a3a90d527e0878eb"
 LIBAPI = 0
-LIBPATCH = 6
+LIBPATCH = 7
 
 SCOPE = "unit"