Skip to content

Commit 0318021

Browse files
Fix missing kwargs in some methods (#236)
## Issue There are some inconsistencies with shared files with mysql-router vm (see [PR 143](canonical/mysql-router-operator#143) ## Solution Fix inconsistencies
1 parent 7aba973 commit 0318021

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/kubernetes_upgrade.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ def determine_partition() -> int:
241241
def authorized(self) -> bool:
242242
raise Exception("Not supported on Kubernetes")
243243

244-
def upgrade_unit(self, *, workload_: workload.Workload, tls: bool) -> None:
244+
def upgrade_unit(self, *, event, workload_: workload.Workload, tls: bool) -> None:
245245
raise Exception("Not supported on Kubernetes")
246246

247247

src/upgrade.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def authorized(self) -> bool:
223223
"""
224224

225225
@abc.abstractmethod
226-
def upgrade_unit(self, *, workload_: workload.Workload, tls: bool) -> None:
226+
def upgrade_unit(self, *, event, workload_: workload.Workload, tls: bool) -> None:
227227
"""Upgrade this unit.
228228
229229
Only applies to machine charm

src/workload.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ def upgrade(
430430
if enabled:
431431
logger.debug("Disabling MySQL Router service before upgrade")
432432
self._disable_router()
433-
super().upgrade(unit=unit, tls=tls, exporter_config=exporter_config)
433+
super().upgrade(event=event, unit=unit, tls=tls, exporter_config=exporter_config)
434434
if enabled:
435435
logger.debug("Re-enabling MySQL Router service after upgrade")
436436
self._enable_router(event=event, tls=tls, unit_name=unit.name)

0 commit comments

Comments
 (0)