Skip to content

Commit e9bf8df

Browse files
Update Router to 8.0.42 & add s390x arch (#455)
Since there are only 3 IS-hosted s390x github runners, will add s390x integration tests in a separate PR to avoid blocking PRs
1 parent 31f85f2 commit e9bf8df

File tree

11 files changed

+16
-10
lines changed

11 files changed

+16
-10
lines changed

.github/workflows/approve_renovate_pr.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ on:
1010
jobs:
1111
approve-pr:
1212
name: Approve Renovate pull request
13-
uses: canonical/data-platform-workflows/.github/workflows/approve_renovate_pr.yaml@v31.1.1
13+
uses: canonical/data-platform-workflows/.github/workflows/approve_renovate_pr.yaml@v32.2.0
1414
permissions:
1515
pull-requests: write # Needed to approve PR

.github/workflows/check_pr.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ on:
1515
jobs:
1616
check-pr:
1717
name: Check pull request
18-
uses: canonical/data-platform-workflows/.github/workflows/check_charm_pr.yaml@v31.1.1
18+
uses: canonical/data-platform-workflows/.github/workflows/check_charm_pr.yaml@v32.2.0

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353

5454
build:
5555
name: Build charm
56-
uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@v31.1.1
56+
uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@v32.2.0
5757

5858
integration-test:
5959
name: Integration test charm

.github/workflows/promote.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ on:
2525
jobs:
2626
promote:
2727
name: Promote charm
28-
uses: canonical/data-platform-workflows/.github/workflows/[email protected]
28+
uses: canonical/data-platform-workflows/.github/workflows/[email protected] # Use v32 after this charm adds refresh v3
2929
with:
3030
track: '8.0'
3131
from-risk: ${{ inputs.from-risk }}

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
name: Release charm
2323
needs:
2424
- ci-tests
25-
uses: canonical/data-platform-workflows/.github/workflows/release_charm.yaml@v31.1.1
25+
uses: canonical/data-platform-workflows/.github/workflows/release_charm.yaml@v32.2.0
2626
with:
2727
channel: 8.0/edge
2828
artifact-prefix: ${{ needs.ci-tests.outputs.artifact-prefix }}

.github/workflows/sync_docs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
jobs:
1111
sync-docs:
1212
name: Sync docs from Discourse
13-
uses: canonical/data-platform-workflows/.github/workflows/sync_docs.yaml@v31.1.1
13+
uses: canonical/data-platform-workflows/.github/workflows/sync_docs.yaml@v32.2.0
1414
with:
1515
reviewers: a-velasco
1616
permissions:

charmcraft.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ type: charm
55
platforms:
66
77
8+
89
# Files implicitly created by charmcraft without a part:
910
# - dispatch (https://github.com/canonical/charmcraft/pull/1898)
1011
# - manifest.yaml

metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,6 @@ resources:
6060
mysql-router-image:
6161
type: oci-image
6262
description: OCI image for mysql-router
63-
upstream-source: ghcr.io/canonical/charmed-mysql@sha256:089fc04dd2d6f1559161ddf4720c1e06559aeb731ecae57b050c9c816e9833e9
63+
upstream-source: ghcr.io/canonical/charmed-mysql@sha256:e78bdba30923ec87d67879a284d9162dfbb7600b34cbf3f84c9b4cce08648715
6464
assumes:
6565
- k8s-api

src/architecture.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,10 @@ def is_wrong_architecture() -> bool:
5151
manifest_archs.extend(base_archs)
5252

5353
hardware_arch = platform.machine()
54-
if ("amd64" in manifest_archs and hardware_arch == "x86_64") or (
55-
"arm64" in manifest_archs and hardware_arch == "aarch64"
54+
if (
55+
("amd64" in manifest_archs and hardware_arch == "x86_64")
56+
or ("arm64" in manifest_archs and hardware_arch == "aarch64")
57+
or ("s390x" in manifest_archs and hardware_arch == "s390x")
5658
):
5759
logger.debug("Charm architecture matches")
5860
return False

tests/integration/test_architecture.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,3 +59,6 @@ async def test_amd_charm_on_arm_host(ops_test: OpsTest) -> None:
5959
status="error",
6060
raise_on_error=False,
6161
)
62+
63+
64+
# TODO: add s390x test

0 commit comments

Comments
 (0)