Update ops to v2.14 #273
Open
Update ops to v2.14 #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for breaking change in ops 2.10: canonical/operator#1091 (comment) Workaround may break during deferred ops events or collect status ops events (canonical/operator#1091 (comment))
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
1 task
paulomach
approved these changes
Jun 26, 2024
as currently written, yes (we don't use collect status or deferred events) but this change in ops will prevent this charm from using deferred or custom events in the future |
taurus-forever
approved these changes
Jun 27, 2024
1 task
|
@paulomach what is our pissition here? Renovate pushes us to ops 2.15 (security update)... but we need to make decision here first AFAIK. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for breaking change in ops 2.10: canonical/operator#1091 (comment)
Workaround may break during deferred ops events or collect status ops events (canonical/operator#1091 (comment))