Add refresh v3 implementation (#241)

Uses `charm-refresh` Python package:
https://github.com/canonical/charm-refresh

---------

Co-authored-by: Sinclert Pérez <[email protected]>

Author: carlcsaposs-canonical

.github/workflows/approve_renovate_pr.yaml

@@ -10,6 +10,6 @@ on:
 jobs:
   approve-pr:
     name: Approve Renovate pull request
-    uses: canonical/data-platform-workflows/.github/workflows/approve_renovate_pr.yaml@v31.0.1
+    uses: canonical/data-platform-workflows/.github/workflows/approve_renovate_pr.yaml@v32.0.0
     permissions:
       pull-requests: write  # Needed to approve PR

.github/workflows/check_pr.yaml

@@ -15,4 +15,4 @@ on:
 jobs:
   check-pr:
     name: Check pull request
-    uses: canonical/data-platform-workflows/.github/workflows/check_charm_pr.yaml@v31.0.1
+    uses: canonical/data-platform-workflows/.github/workflows/check_charm_pr.yaml@v32.0.0

.github/workflows/ci.yaml

@@ -55,7 +55,7 @@ jobs:
 
   build:
     name: Build charm
-    uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@v31.0.1
+    uses: canonical/data-platform-workflows/.github/workflows/build_charm.yaml@v32.0.0
 
   integration-test:
     name: Integration test charm

.github/workflows/promote.yaml

@@ -25,7 +25,7 @@ on:
 jobs:
   promote:
     name: Promote charm
-    uses: canonical/data-platform-workflows/.github/workflows/_promote_charm.yaml@v31.0.1
+    uses: canonical/data-platform-workflows/.github/workflows/_promote_charm.yaml@v32.0.0
     with:
       track: 'dpe'
       from-risk: ${{ inputs.from-risk }}

.github/workflows/release.yaml

@@ -1,6 +1,6 @@
 # Copyright 2023 Canonical Ltd.
 # See LICENSE file for licensing details.
-name: Release to Charmhub
+name: Release to Charmhub edge
 
 on:
   push:
@@ -13,8 +13,18 @@ on:
       - '.github/workflows/sync_docs.yaml'
 
 jobs:
+  tag:
+    name: Create charm refresh compatibility version git tag
+    uses: canonical/data-platform-workflows/.github/workflows/[email protected]
+    with:
+      track: 'dpe'
+    permissions:
+      contents: write  # Needed to create git tag
+
   ci-tests:
     name: Tests
+    needs:
+      - tag
     uses: ./.github/workflows/ci.yaml
     secrets: inherit
     permissions:
@@ -23,12 +33,13 @@ jobs:
   release:
     name: Release charm
     needs:
+      - tag
       - ci-tests
-    uses: canonical/data-platform-workflows/.github/workflows/release_charm.yaml@v31.0.1
+    uses: canonical/data-platform-workflows/.github/workflows/release_charm_edge.yaml@v32.0.0
     with:
-      channel: dpe/edge
+      track: ${{ needs.tag.outputs.track }}
       artifact-prefix: ${{ needs.ci-tests.outputs.artifact-prefix }}
     secrets:
       charmhub-token: ${{ secrets.CHARMHUB_TOKEN }}
     permissions:
-      contents: write  # Needed to create GitHub release
+      contents: write  # Needed to create git tags

.github/workflows/sync_docs.yaml

@@ -10,7 +10,7 @@ on:
 jobs:
   sync-docs:
     name: Sync docs from Discourse
-    uses: canonical/data-platform-workflows/.github/workflows/sync_docs.yaml@v31.0.1
+    uses: canonical/data-platform-workflows/.github/workflows/sync_docs.yaml@v32.0.0
     with:
       reviewers: a-velasco
     permissions:

actions.yaml

@@ -1,18 +1,61 @@
 # Copyright 2023 Canonical Ltd.
 # See LICENSE file for licensing details.
 
-resume-upgrade:
-  description: Upgrade remaining units (after you manually verified that upgraded units are healthy).
-
-force-upgrade:
+pre-refresh-check:
+  description: Check if charm is ready to refresh
+  additionalProperties: false
+force-refresh-start:
   description: |
-    Potential of *data loss* and *downtime*
+    Potential of data loss and downtime
+    
+    Force refresh of first unit
+    
+    Must run with at least one of the parameters `=false`
+  params:
+    check-compatibility:
+      type: boolean
+      default: true
+      description: |
+        Potential of data loss and downtime
+        
+        If `false`, force refresh if new version of Router and/or charm is not compatible with previous version
+    run-pre-refresh-checks:
+      type: boolean
+      default: true
+      description: |
+        Potential of data loss and downtime
+        
+        If `false`, force refresh if app is unhealthy or not ready to refresh (and unit status shows "Pre-refresh check failed")
+    check-workload-container:
+      type: boolean
+      default: true
+      description: |
+        Potential of data loss and downtime during and after refresh
         
-    Force upgrade of this unit.
+        If `false`, allow refresh to Router container version that has not been validated to work with the charm revision
+  additionalProperties: false
+resume-refresh:
+  description: |
+    Refresh next unit(s) (after you have manually verified that refreshed units are healthy)
+    
+    If the `pause_after_unit_refresh` config is set to `all`, this action will refresh the next unit.
+    
+    If `pause_after_unit_refresh` is set to `first`, this action will refresh all remaining units.
+    Exception: if automatic health checks fail after a unit has refreshed, the refresh will pause.
     
-    Use to
-    - force incompatible upgrade and/or
-    - continue upgrade if 1+ upgraded units have non-active status
+    If `pause_after_unit_refresh` is set to `none`, this action will have no effect unless it is called with `check-health-of-refreshed-units` as `false`.
+  params:
+    check-health-of-refreshed-units:
+      type: boolean
+      default: true
+      description: |
+        Potential of data loss and downtime
+        
+        If `false`, force refresh (of next unit) if 1 or more refreshed units are unhealthy
+        
+        Warning: if first unit to refresh is unhealthy, consider running `force-refresh-start` action on that unit instead of using this parameter.
+        If first unit to refresh is unhealthy because compatibility checks, pre-refresh checks, or workload container checks are failing, this parameter is more destructive than the `force-refresh-start` action.
+  additionalProperties: false
 
 set-tls-private-key:
   description:

charm_version

@@ -83,18 +83,20 @@ parts:
   files:
     plugin: dump
     source: .
+    after:
+      - poetry-deps  # Ensure poetry is installed
     build-packages:
       - git
     override-build: |
-      # Workaround to add unique identifier (git hash) to charm version while specification
-      # DA053 - Charm versioning
-      # (https://docs.google.com/document/d/1Jv1jhWLl8ejK3iJn7Q3VbCIM9GIhp8926bgXpdtx-Sg/edit?pli=1)
-      # is pending review.
-      python3 -c 'import pathlib; import shutil; import subprocess; git_hash=subprocess.run(["git", "describe", "--always", "--dirty"], capture_output=True, check=True, encoding="utf-8").stdout; file = pathlib.Path("charm_version"); shutil.copy(file, pathlib.Path("charm_version.backup")); version = file.read_text().strip(); file.write_text(f"{version}+{git_hash}")'
+      # Set `charm_version` in refresh_versions.toml from git tag
+      # Create venv in `..` so that git working tree is not dirty
+      python3 -m venv ../refresh-version-venv
+      source ../refresh-version-venv/bin/activate
+      poetry install --only build-refresh-version
+      write-charm-version
 
       craftctl default
     stage:
       - LICENSE
-      - charm_version
-      - workload_version
+      - refresh_versions.toml
       - templates

charmcraft.yaml

@@ -2,8 +2,14 @@
 # See LICENSE file for licensing details.
 
 options:
-
   vip:
     description: |
       Virtual IP to use to front mysql router units. Used only in case of external node connection.
     type: string
+  pause_after_unit_refresh:
+    description: |
+      Wait for manual confirmation to resume refresh after these units refresh
+
+      Allowed values: "all", "first", "none"
+    type: string
+    default: first